-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add immediate
prop to <Combobox />
for immediately opening the Combobox when the input
receives focus
#2686
Add immediate
prop to <Combobox />
for immediately opening the Combobox when the input
receives focus
#2686
Commits on Aug 31, 2023
-
Configuration menu - View commit details
-
Copy full SHA for aded397 - Browse repository at this point
Copy the full SHA aded397View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4d40e13 - Browse repository at this point
Copy the full SHA 4d40e13View commit details -
ensure tabbing through a few fields, doesn't result in an incorrectly…
… selected item When you have a fwe inputs such as: ```html <form> <input /> <input /> <input /> <Combobox> <Combobox.Input /> </Combobox> <input /> <input /> <input /> </form> ``` Tabbing through this list will open the combobox once you are on the input field. When you continue tabbing, the first item would be selected. However, if the combobox is not marked as nullable, it means that just going through the form means that we set a value we can't unset anymore. We still want to open the combobox, we just don't want to select anything in this case.
Configuration menu - View commit details
-
Copy full SHA for bae4b64 - Browse repository at this point
Copy the full SHA bae4b64View commit details -
only
openOnFocus
if the<Combobox.Input />
is focused from theoutside If the focus is coming from the `<Combobox.Button />` or as a side effect of selecting an `<Combobox.Option />` then we don't want to re-open the `<Combobox />`
Configuration menu - View commit details
-
Copy full SHA for bdfec75 - Browse repository at this point
Copy the full SHA bdfec75View commit details -
Configuration menu - View commit details
-
Copy full SHA for 29e7057 - Browse repository at this point
Copy the full SHA 29e7057View commit details -
Configuration menu - View commit details
-
Copy full SHA for dc6dccf - Browse repository at this point
Copy the full SHA dc6dccfView commit details -
only select the active option when the Combobox wasn't opened by focu…
…sing the input field
Configuration menu - View commit details
-
Copy full SHA for 4577735 - Browse repository at this point
Copy the full SHA 4577735View commit details -
Configuration menu - View commit details
-
Copy full SHA for 08d337a - Browse repository at this point
Copy the full SHA 08d337aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 318485a - Browse repository at this point
Copy the full SHA 318485aView commit details -
ensure we see the "relatedTarget" in Safari
Safari doesn't fire a `focus` event when clicking a button, therefore it does not become the `document.activeElement`, and events like `blur` or `focus` doesn't set the button as the `event.relatedTarget`. Keeping track of a history like this solves that problem. We already had the code for the `FocusTrap` component.
Configuration menu - View commit details
-
Copy full SHA for 07f05f5 - Browse repository at this point
Copy the full SHA 07f05f5View commit details