Skip to content

Commit

Permalink
update failing test
Browse files Browse the repository at this point in the history
The order slightly changed here, but it looks more correct now as well.
The `child-2-1` and `child-2-2` have the same duration/delay, so the
order that they are rendered in seems to be the correct order.

That said, these DOM nodes are on the same level (siblings), so for
these callbacks we are testing here the order doesn't really matter. The
order that _does_ matter is that the `after*` events of a parent fire
_after_ the `after*` events of the children, which it still does.
  • Loading branch information
RobinMalfait committed Sep 4, 2024
1 parent 62a2ae2 commit fe1b1a6
Showing 1 changed file with 4 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -1050,8 +1050,8 @@ describe('Events', () => {
'child-2-2: beforeEnter',

'child-1: afterEnter',
'child-2-2: afterEnter',
'child-2-1: afterEnter',
'child-2-2: afterEnter',
'child-2: afterEnter',
'root: afterEnter',

Expand All @@ -1064,8 +1064,8 @@ describe('Events', () => {
'root: beforeLeave',

'child-1: afterLeave',
'child-2-2: afterLeave',
'child-2-1: afterLeave',
'child-2-2: afterLeave',
'child-2: afterLeave',
'root: afterLeave',

Expand All @@ -1078,8 +1078,8 @@ describe('Events', () => {
'child-2-2: beforeEnter',

'child-1: afterEnter',
'child-2-2: afterEnter',
'child-2-1: afterEnter',
'child-2-2: afterEnter',
'child-2: afterEnter',
'root: afterEnter',

Expand All @@ -1092,8 +1092,8 @@ describe('Events', () => {
'root: beforeLeave',

'child-1: afterLeave',
'child-2-2: afterLeave',
'child-2-1: afterLeave',
'child-2-2: afterLeave',
'child-2: afterLeave',
'root: afterLeave',
])
Expand Down

0 comments on commit fe1b1a6

Please sign in to comment.