-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Add
multi
value support for Listbox & Combobox (#1243)
* First attempt at a multi-listbox * implement `multiple` mode on Listbox * add multiple Listbox example to playground * implement `multiple` mode on Combobox * make sure groupContext is not undefined or null On vercel, getting a strange issue like `TypeError: undefined is not an object (evaluating 'r.resolveTarget')` which doesn't happen locally or once published. Would expect it to be `null` since we default to `null`. Hopefully this fixes things. * bump all the dependencies * make sure that `@types/react` use set to the correct version `@types/react-dom` hardcoded the `@types/react` to version `16.14.21` instead of using the latest `16.14.24` resulting in type mismatches. *cries in inconsistency* * update changelog * add multiple Combobox example to playground * refactor Combobox, use actions * use combobox data This is a first step in refactoring everything where we use dedicated actions and data instead of accessing the reducer state directly. It also allows us to get rid of mutations in render where we updated some values in render directly which is not ideal. Co-authored-by: pvanliefland <pierre.vanliefland@gmail.com>
- Loading branch information
1 parent
63383c4
commit 40fee45
Showing
19 changed files
with
2,310 additions
and
976 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.