Tech 1048/cacluate cost elastic ip #703
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eneskaya
previously approved these changes
Apr 5, 2023
eneskaya
reviewed
Apr 5, 2023
providers/aws/ec2/elastic-ips.go
Outdated
Comment on lines
46
to
47
| fetchedAt := time.Now() | ||
| hoursSinceFetched := hoursSince(fetchedAt) |
There was a problem hiding this comment.
Wait, I approved but now I just saw, that this will be always 0 hours, hence 0$ monthly cost
mlabouardy
requested changes
Apr 5, 2023
There was a problem hiding this comment.
You can get the creation date of the IP by leveraging AWS Config.
This command should return the creation date (under configurationItemCaptureTime attribute):
aws configservice batch-get-resource-config --resource-keys resourceType=AWS::EC2::EIP,resourceId=eipalloc-ID_HERE
|
Hey there @eneskaya and @mlabouardy just to let you know that I made some updates (thanks for the help Moh!) |
mlabouardy
force-pushed
the
tech-1048/cacluate-cost-elastic-ip
branch
from
ebd1978 to
87d7b92
Compare
mlabouardy
approved these changes
Apr 7, 2023
There was a problem hiding this comment.
@jakepage91 I've added missing AWS permission to IAM policy file as well handled when the permission is missing otherwise the resource won't be collected
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey there!
I've added a cost calculation part for Elastic IPs here. But, the AWS Go SDK doesn't let me find the exact creation time of the Elastic IP. So, I've come up with a workaround that calculates the cost of unassociated Elastic IPs from the moment they're first fetched. This isn't perfect, though, as it may give inaccurate cost calculations. Unassociated IP addresses will only start counting towards the cost after Komiser fetches them, which could lead to underestimating the actual costs.
Can you think of any better way?
Cheers