include brackets in encoded url chars

package.json

@@ -48,7 +48,7 @@
     "@testing-library/dom": "10.1.0",
     "@types/chai": "4.3.16",
     "@types/jest": "^29.5.12",
-    "@types/node": "20.14.2",
+    "@types/node": "20.14.5",
     "@types/three": "0.165.0",
     "chai": "4.x",
     "ini": "4.1.3",

src/events/recorder.ts

@@ -143,15 +143,7 @@ export class Recorder {
     currentBreak.score = breakScore
     const text = `break(${breakScore})`
     const serialisedShot = JSON.stringify(currentBreak)
-    console.log(`raw:${serialisedShot}`)
     const compressed = JSONCrush.crush(serialisedShot)
-    console.log(`crushed:${compressed}`)
-    console.log(`encoded:${encodeURIComponent(compressed)}`)
-    console.log(`decoded:${decodeURIComponent(encodeURIComponent(compressed))}`)
-
-    const uncompressed = JSONCrush.uncrush(decodeURIComponent(encodeURIComponent(compressed)))
-    console.log(`uncompressed:${uncompressed}`)
-    console.log(serialisedShot == uncompressed)
     this.generateLink(text, compressed, "black")
     if (breakScore >= 4) {
       this.generateHiScoreLink(compressed)
@@ -171,8 +163,7 @@ export class Recorder {
   }
 
   private generateLink(text, state, colour) {
-    const shotUri = `${this.replayUrl}${encodeURIComponent(state)}`
-    console.log(`encoded:${shotUri}`)
+    const shotUri = `${this.replayUrl}${this.fullyEncodeURI(state)}`
     const shotLink = `<a class="pill" style="color: ${colour}" target="_blank" href="${shotUri}">${text}</a>`
     this.container.eventQueue.push(new ChatEvent(null, `${shotLink}`))
   }
@@ -181,8 +172,16 @@ export class Recorder {
     const text = "hi score 🏆"
     const shotUri = `${this.hiScoreUrl}?ruletype=${
       this.container.rules.rulename
-    }&state=${encodeURIComponent(state)}`
+    }&state=${this.fullyEncodeURI(state)}`
     const shotLink = `<a class="pill" target="_blank" href="${shotUri}">${text}</a>`
     this.container.eventQueue.push(new ChatEvent(null, `${shotLink}`))
   }
+
+  private fullyEncodeURI(uri) {
+    return encodeURIComponent(uri)
+    .replace(/\(/g,'%28')
+    .replace(/\)/g,'%29')
+    .replace(/\!/g,'%21')
+    .replace(/\*/g,'%2A')
+  }
 }

yarn.lock

@@ -957,10 +957,10 @@
   dependencies:
     undici-types "~5.26.4"
 
-"@types/node@20.14.2":
-  version "20.14.2"
-  resolved "https://registry.yarnpkg.com/@types/node/-/node-20.14.2.tgz#a5f4d2bcb4b6a87bffcaa717718c5a0f208f4a18"
-  integrity sha512-xyu6WAMVwv6AKFLB+e/7ySZVr/0zLCzOa7rSpq6jNwpqOrUbcACDWC+53d4n2QHOnDou0fbIsg8wZu/sxrnI4Q==
+"@types/node@20.14.5":
+  version "20.14.5"
+  resolved "https://registry.yarnpkg.com/@types/node/-/node-20.14.5.tgz#fe35e3022ebe58b8f201580eb24e1fcfc0f2487d"
+  integrity sha512-aoRR+fJkZT2l0aGOJhuA8frnCSoNX6W7U2mpNq63+BxBIj5BQFt8rHy627kijCmm63ijdSdwvGgpUsU6MBsZZA==
   dependencies:
     undici-types "~5.26.4"