Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tailscale web: Authentication and reauthentication returns empty error #1939

Closed
ivokub opened this issue May 16, 2021 · 5 comments · Fixed by #1998
Closed

tailscale web: Authentication and reauthentication returns empty error #1939

ivokub opened this issue May 16, 2021 · 5 comments · Fixed by #1998
Assignees
Labels

Comments

@ivokub
Copy link

ivokub commented May 16, 2021

I am trying include the Tailscale web interface in QTS (QNAP operating system) so that users wouldn't need to login in with SSH for authenticating the node.

In 1.8, there seems to be a new web interface in Tailscale which seems to be exactly what I would need. However, the included web server returns an empty error:

[/share/CACHEDEV1_DATA/.qpkg/Tailscale] # curl -X POST -H "Accept: application/json" -H "Content-type: application/json" http://localhost:50992/?up=true
{"error":{}}

I tested using Tailscale 1.8.1 and 1.9.44.

Is the web interface supposed to work at all with non-Synology devices?

@bradfitz
Copy link
Member

Is the web interface supposed to work at all with non-Synology devices?

tailscale web? Yeah, that's the plan. We bought two QNAP NASes to work on that but haven't started working on it yet. We just got them online the a few days ago.

/cc @crawshaw

@bradfitz
Copy link
Member

(overall effort for QNAP is #1346)

@ivokub
Copy link
Author

ivokub commented May 16, 2021

Is the web interface supposed to work at all with non-Synology devices?

tailscale web? Yeah, that's the plan. We bought two QNAP NASes to work on that but haven't started working on it yet. We just got them online the a few days ago.

/cc @crawshaw

So, currently tailscale web is not supposed to work correctly? I tried to understand if it is something specific to my setup, but upon closer inspection it seems to be a problem with the command itself.
Here an interactive login is started on the backend, but the client does not wait for backend reply and returns immediately in the next line. When I added

select {
	case <-gotEngineUpdate:
	case <-pumpCtx.Done():
		return authURL, pumpCtx.Err()
	}

between lines 321 and 323, then I got the client working and properly authenticating.

@apenwarr apenwarr changed the title Authentication and reauthentication returns empty error using web interface tailscale web: Authentication and reauthentication returns empty error May 18, 2021
@bradfitz
Copy link
Member

@crawshaw, you want to own this?

@crawshaw
Copy link
Contributor

@ivokub We want tailscale web to work but it may be accidentally broken. Let me see if I can get it working.

crawshaw added a commit that referenced this issue May 27, 2021
For #1939

Signed-off-by: David Crawshaw <crawshaw@tailscale.com>
crawshaw added a commit that referenced this issue May 27, 2021
Fixes #1939

Signed-off-by: David Crawshaw <crawshaw@tailscale.com>
crawshaw added a commit that referenced this issue May 27, 2021
Fixes #1939

Signed-off-by: David Crawshaw <crawshaw@tailscale.com>
crawshaw added a commit that referenced this issue May 27, 2021
For #1939

Signed-off-by: David Crawshaw <crawshaw@tailscale.com>
crawshaw added a commit that referenced this issue May 27, 2021
Fixes #1939

Signed-off-by: David Crawshaw <crawshaw@tailscale.com>
crawshaw added a commit that referenced this issue May 27, 2021
For #1939

Signed-off-by: David Crawshaw <crawshaw@tailscale.com>
crawshaw added a commit that referenced this issue May 27, 2021
Fixes #1939

Signed-off-by: David Crawshaw <crawshaw@tailscale.com>
bradfitz pushed a commit that referenced this issue May 27, 2021
For #1939

Signed-off-by: David Crawshaw <crawshaw@tailscale.com>
(cherry picked from commit 50c976d)
bradfitz pushed a commit that referenced this issue May 27, 2021
Fixes #1939

Signed-off-by: David Crawshaw <crawshaw@tailscale.com>
(cherry picked from commit 82b217f)
simenghe pushed a commit that referenced this issue May 27, 2021
For #1939

Signed-off-by: David Crawshaw <crawshaw@tailscale.com>
Signed-off-by: Simeng He <simeng@tailscale.com>
simenghe pushed a commit that referenced this issue May 27, 2021
Fixes #1939

Signed-off-by: David Crawshaw <crawshaw@tailscale.com>
Signed-off-by: Simeng He <simeng@tailscale.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants