Skip to content

Commit

Permalink
cmd/tailscale: fix inverted flag meanings.
Browse files Browse the repository at this point in the history
The flags were --no-blah for a brief time, then we switched them to
--blah=true/false with a default of true, but didn't fix the boolean
inversions in the code. So up was down, true was false, etc.

Signed-off-by: David Anderson <danderson@tailscale.com>
  • Loading branch information
danderson committed Jun 3, 2020
1 parent cc687fc commit c62b80e
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions cmd/tailscale/tailscale.go
Original file line number Diff line number Diff line change
Expand Up @@ -200,11 +200,11 @@ func runUp(ctx context.Context, args []string) error {
prefs.ControlURL = upArgs.server
prefs.WantRunning = true
prefs.RouteAll = upArgs.acceptRoutes
prefs.AllowSingleHosts = !upArgs.singleRoutes
prefs.AllowSingleHosts = upArgs.singleRoutes
prefs.ShieldsUp = upArgs.shieldsUp
prefs.AdvertiseRoutes = routes
prefs.AdvertiseTags = tags
prefs.NoSNAT = upArgs.snat
prefs.NoSNAT = !upArgs.snat
prefs.DisableDERP = !upArgs.enableDERP
if runtime.GOOS == "linux" {
switch upArgs.netfilterMode {
Expand Down

0 comments on commit c62b80e

Please sign in to comment.