-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#13 Support Jakarta EE 10 #14
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please rewrite the commit message to the semver pattern. Use the key "breaking" to trigger a new major version on releasing.
Example:
breaking: support jakarta EE10
I had followed the description in https://github.com/semantic-release/semantic-release for the commit message, where the label was "BREAKING CHANGE". |
Yes, it must be part of the headline. See here: https://github.com/prolutionsGmbH/herasaf-xacml-core/blob/main/ci/GitVersion.yml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Could you please rename the commit headline to
BREAKING CHANGE: support Jakarta EE 10 (#13)
Then I can approve the pr and create a release.
* Update to java 11 * switch to jakarta xml bind * some dependency updates
BREAKING CHANGE: Java 11 is now required and J2EE 10