Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#13 Support Jakarta EE 10 #14

Merged
merged 1 commit into from
Jul 13, 2023
Merged

#13 Support Jakarta EE 10 #14

merged 1 commit into from
Jul 13, 2023

Conversation

Thopap
Copy link
Contributor

@Thopap Thopap commented Jul 7, 2023

  • Update to java 11
  • switch to jakarta xml bind
  • some dependency updates

BREAKING CHANGE: Java 11 is now required and J2EE 10

Copy link

@fhuonder fhuonder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rewrite the commit message to the semver pattern. Use the key "breaking" to trigger a new major version on releasing.

Example:
breaking: support jakarta EE10

src/main/java/org/herasaf/xacml/core/types/Time.java Outdated Show resolved Hide resolved
@Thopap
Copy link
Contributor Author

Thopap commented Jul 10, 2023

Please rewrite the commit message to the semver pattern. Use the key "breaking" to trigger a new major version on releasing.

Example: breaking: support jakarta EE10

I had followed the description in https://github.com/semantic-release/semantic-release for the commit message, where the label was "BREAKING CHANGE".
If i understand the definition correctly, the "BREAKING CHANGE: " prefix must be part of the commit headline instead of the footer that i have choosen, correct?

@fhuonder
Copy link

Please rewrite the commit message to the semver pattern. Use the key "breaking" to trigger a new major version on releasing.
Example: breaking: support jakarta EE10

I had followed the description in https://github.com/semantic-release/semantic-release for the commit message, where the label was "BREAKING CHANGE". If i understand the definition correctly, the "BREAKING CHANGE: " prefix must be part of the commit headline instead of the footer that i have choosen, correct?

Yes, it must be part of the headline. See here: https://github.com/prolutionsGmbH/herasaf-xacml-core/blob/main/ci/GitVersion.yml
Can be "breaking:" or "BREAKING CHANGE:"

Copy link

@fhuonder fhuonder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Could you please rename the commit headline to
BREAKING CHANGE: support Jakarta EE 10 (#13)

Then I can approve the pr and create a release.

* Update to java 11
* switch to jakarta xml bind
* some dependency updates
@fhuonder fhuonder merged commit ef1fc07 into tailorfastGmbH:main Jul 13, 2023
@fhuonder fhuonder mentioned this pull request Jul 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants