Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(475): Redesign Landing Page for the Blog #488

Merged
merged 38 commits into from
Oct 4, 2024

Conversation

neo773
Copy link
Contributor

@neo773 neo773 commented Sep 9, 2024

a.mp4

/claim #475
/closes #475

@neo773 neo773 force-pushed the home-blog-redesign branch from 81bcf04 to deb85b4 Compare September 9, 2024 20:26
@neo773 neo773 force-pushed the home-blog-redesign branch from 486813e to 88ffe95 Compare September 9, 2024 21:58
@neo773
Copy link
Contributor Author

neo773 commented Sep 18, 2024

@tusharmath
Could I get a review on this?

@amitksingh1490
Copy link
Contributor

image Responsiveness is broken

@amitksingh1490 amitksingh1490 marked this pull request as draft September 22, 2024 10:20
@neo773 neo773 marked this pull request as ready for review September 22, 2024 20:04
@neo773
Copy link
Contributor Author

neo773 commented Sep 22, 2024

@amitksingh1490
Could you check again? updated mobile design to match Figma file it was using Desktop layout before.

@neo773
Copy link
Contributor Author

neo773 commented Sep 27, 2024

@neo773 it would be my pleasure collaborating with you on this one.

I mean it's a done PR I'm not sure what's there to collaborate at this stage.

@neo773 neo773 marked this pull request as ready for review September 27, 2024 13:43
@amitksingh1490
Copy link
Contributor

image (13) Still design is not matching, moving this to draft

@amitksingh1490 amitksingh1490 marked this pull request as draft September 28, 2024 07:07
@neo773
Copy link
Contributor Author

neo773 commented Sep 28, 2024

@amitksingh1490
About the tags, when I spoke with Tushar he wanted a separate category field in the frontmatter instead of using tags.
I can change it back let me know.

Some of the images have a white border the layout itself is fine

image

As for spacing pushed a new commit

@amitksingh1490
Copy link
Contributor

What about featured post still coming even though nothing is marked as featured.

@neo773
Copy link
Contributor Author

neo773 commented Sep 29, 2024

What about featured post still coming even though nothing is marked as featured.

Fixed, I assumed we'll always have one featured post since the Figma file didn't have an empty state UI

docusaurus.config.ts Outdated Show resolved Hide resolved
@amitksingh1490
Copy link
Contributor

image image Image getting cropped. image featured section is visible in the tab even if there is no space for it.

@neo773 neo773 marked this pull request as ready for review October 3, 2024 18:49
@neo773
Copy link
Contributor Author

neo773 commented Oct 3, 2024

changed images to object-contain but these images will need to replaced in my opinion they have no consistency in dimensions.

@tusharmath tusharmath closed this Oct 4, 2024
@tusharmath tusharmath reopened this Oct 4, 2024
@amitksingh1490 amitksingh1490 enabled auto-merge (squash) October 4, 2024 07:29
@amitksingh1490 amitksingh1490 merged commit 71b2ebb into tailcallhq:develop Oct 4, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Redesign Landing Page for the Blog
4 participants