feat(gwyneth): incorporate booster sample contracts #26
Conversation
| // Only stored on L1 | ||
| // Currently getBlockHash() is not supported via the new Taiko Gwyneth | ||
| //ITaiko public taiko; | ||
| // todo (@Brecht): XChain has a bus property but Bus is an XChain (inherits). It does not make too much sense to me, or maybe i'm missing the point ? |
There was a problem hiding this comment.
The bus might still be needed for async transactions to pass data from one chain to the other, but I guess to keep things simple let's assume synchronous everywhere for now.
| // These could also be exposed using a precompile because we could get them from public input, | ||
| // but that requires extra work so let's just fetch them from L1 for now | ||
| function getBlockHash(uint chainID, uint blockID) external view xExecuteOn(EVM.l1ChainId) returns (bytes32) { | ||
| // todo(@Brecht): Currently not supported or well, at least TaikoL1 does not have it with the current design. |
There was a problem hiding this comment.
Right, outdated! Hmmmm only needed for async case so let's skip for now.
|
Let's assume a wondrous fully synchronous world 🌈 . XCALLOPTIONS is able to do any call to any chain, so we can avoid the Bus for now. |
Currently i can move synch-only code (from Questions: Would be cool to go thru diff.
|
…ritance feat(gwyneth): Modify `xChainToken` inheritance
There are some questions ariesed, i tried to asked them in form of some comments.
Also some libraries/contracts/interfaces like:
IExternalL2,IExternalL2Bridge,DemoReadFromExternalL2,Create2,IProxy,WalletProxy,SmartWallet,WalletFactoryare missing because first wanted to try with a simple erc20.