Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(gwyneth): initial draft of the issue desc. #24

Merged
merged 8 commits into from
Jul 22, 2024
Merged

Conversation

adaki2004
Copy link

Draft of the described, simplified protocol here: #22

@adaki2004 adaki2004 requested a review from Brechtpd July 17, 2024 10:40
@adaki2004 adaki2004 marked this pull request as draft July 17, 2024 10:43
packages/protocol/contracts/L1/ChainProver.sol Outdated Show resolved Hide resolved
packages/protocol/contracts/L1/ChainProver.sol Outdated Show resolved Hide resolved
packages/protocol/contracts/L1/TaikoL1.sol Outdated Show resolved Hide resolved
packages/protocol/contracts/L1/TaikoL1.sol Outdated Show resolved Hide resolved
packages/protocol/contracts/L1/verifiers/IVerifier.sol Outdated Show resolved Hide resolved
packages/protocol/contracts/L1/ChainProver.sol Outdated Show resolved Hide resolved
packages/protocol/contracts/L1/ChainProver.sol Outdated Show resolved Hide resolved
@adaki2004
Copy link
Author

adaki2004 commented Jul 17, 2024

  • fix PR comments
  • make it buildable /tests
  • make deployments + proposeBlock script
  • maybe make install (install kurtosis if not installed on mac or linux + runnig a node + deploy L1 smart contracts, see if i can config static PORT... (?) )
  • integrate into CI (?)

@adaki2004
Copy link
Author

adaki2004 commented Jul 19, 2024

@Brechtpd Makefile is added to packages/protocol. (Tested with macOs, but shall work with ubuntu too)

It currently only up your local image (taiko_reth) based network. If the local taiko_reth named image not found, it builds it with that name. If found, uses that. (So in case you change something in the codebase but you have the image from a prev. version, you gotta rebuild it with same tag yourself before using the setup script.)

Also currently the deployment (DeployL1Locally.s.sol, but you can deploy yourself with the 1-liner command in local_deployments.md) is not available because default Kurtosis is running with random, ephemeral ports, so i either need a custom script to detect the RPC or dive deeper into Kurtosis if possible to use static port binding.

@adaki2004
Copy link
Author

...currently the deployment (DeployL1Locally.s.sol, but you can deploy yourself with the 1-liner command in local_deployments.md) is not available because default Kurtosis is running with random, ephemeral ports, so i either need a custom script to detect the RPC or dive deeper into Kurtosis if possible to use static port binding.

Ok, make install now works, and deploys the contracts. (Port is still dynamic, but parsed out from the Kurtosis logs to support deployment.).
Also tested on ubuntu 20.04, and setup works.

Firing away the first proposeBlock() transaction can be done via the script:
forge script --rpc-url http://127.0.0.1:YOUR_PORT scripts/L2_txn_simulation/ProposeBlock.s.sol -vvvv --broadcast --private-key <PK_FROM_SAMPLE_ENV_IS_FINE> --legacy

@adaki2004 adaki2004 requested a review from Brechtpd July 22, 2024 11:56
@adaki2004 adaki2004 marked this pull request as ready for review July 22, 2024 11:56
@Brechtpd Brechtpd merged commit d6079da into gwyneth Jul 22, 2024
13 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants