feat: release taiko reth v1.0.0 #12
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nto feat/support_t8n_and_taikop
…nto feat/support_t8n_and_taikop
Fix missing imports Fix yielding error Fix missmatched types Fix proper state building
smtmfft
approved these changes
Aug 27, 2024
Makefile
Outdated
|
|
||
| docker buildx build --file ./DockerfileTaiko.cross . \ | ||
| --platform linux/amd64,linux/arm64 \ | ||
| #--platform linux/amd64,linux/arm64 \ |
| @@ -1383,7 +1383,7 @@ mod tests { | |||
| // Execute the block and capture the result | |||
| let exec_result = executor.execute( | |||
| ( | |||
| &Block { | |||
| &mut Block { | |||
There was a problem hiding this comment.
We changed the API of executor because we need to remove the invalid transactions from Block in taiko protocol
| @@ -85,7 +85,8 @@ pub fn decode_anchor(bytes: &[u8]) -> Result<anchorCall> { | |||
| /// the corresponding enocding function in protocol is `LibProposing._encodeGasConfigs`. | |||
| pub fn decode_ontake_extra_data(extradata: &[u8]) -> u8 { | |||
| let basefee_ratio = U256::from_be_slice(extradata); | |||
There was a problem hiding this comment.
This byte's order depends on the byte-endian of runing machines
| @@ -9,15 +10,15 @@ use reth_provider::{ | |||
| DatabaseProviderRwFactory, ProviderError, | |||
| }; | |||
| use reth_storage_errors::provider::ProviderResult; | |||
| use taiko_reth_primitives::{HeadL1Origin, HeadL1OriginKey, L1Origin, L1Origins}; | |||
| use taiko_reth_primitives::{HeadL1OriginKey, L1Origin}; | |||
|
|
|||
| /// The trait for fetch L1 origin related data. | |||
| #[auto_impl::auto_impl(&, Arc)] | |||
| pub trait L1OriginReader: Send + Sync { | |||
| /// Get the L1 origin for the given block hash. | |||
There was a problem hiding this comment.
given block number.
a question: should we keep the hash query?
There was a problem hiding this comment.
Keep the same between geth and reth
| @@ -9,7 +9,7 @@ use taiko_reth_primitives::L1Origin; | |||
| pub trait TaikoApi { | |||
| /// HeadL1Origin returns the latest L2 block's corresponding L1 origin. | |||
There was a problem hiding this comment.
l1 origin means the l1 block where this l2 proposal is in??
|
BTW: maybe you can the corresponding revm change for ontake here. |
- Set muir_glacier_block to None - Set arrow_glacier_block to None - Set gray_glacier_block to None - Set cancun_time to None
This commit refactors the `BlockExecutionInput` struct in the `execute.rs` file of the `evm` crate. It replaces the `disable_anchor` field with an `enable_anchor` field and adds an `enable_skip` field. These options allow for enabling or disabling the anchor transaction and skipping invalid transactions during block execution. Ref: paradigmxyz#1234
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Taiko reth v1.0.0 release notes
1. Main changes
1.1. Beacon engine
1.2. P2P syncing
1.3. Proposer
1.4. Revm