Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(bridge-ui): tooltips enhance #463

Merged
merged 5 commits into from
Dec 21, 2022
Merged

feat(bridge-ui): tooltips enhance #463

merged 5 commits into from
Dec 21, 2022

Conversation

d1onys1us
Copy link
Contributor

@d1onys1us d1onys1us commented Dec 20, 2022

summary

  • moved to https://github.com/shinokada/svelte-heros-v2 (hero icons are a good standard imo, made by tailwindcss)
  • removed metamask logo from chain dropdown (this is not wallet specific)
  • fixed alignment for token select dropdown and address dropdown
  • disable memo by default and fix onclick bug firing the memo
  • cleaned up navbar to be full width and correctly responsive, and made taiko logo smaller

screenshots

desktop

image

### mobile

image

@codecov
Copy link

codecov bot commented Dec 20, 2022

Codecov Report

Merging #463 (f6d4e0b) into tooltips (6ee7d25) will increase coverage by 0.14%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##           tooltips     #463      +/-   ##
============================================
+ Coverage     66.34%   66.48%   +0.14%     
============================================
  Files           101      102       +1     
  Lines          2775     2787      +12     
  Branches        324      328       +4     
============================================
+ Hits           1841     1853      +12     
  Misses          860      860              
  Partials         74       74              
Flag Coverage Δ *Carryforward flag
bridge-ui 99.10% <ø> (+0.05%) ⬆️
protocol 58.97% <ø> (ø) Carriedforward from eafff1a
relayer 68.92% <ø> (ø) Carriedforward from eafff1a
ui 100.00% <ø> (ø) Carriedforward from eafff1a

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
packages/bridge-ui/src/domain/chain.ts 100.00% <0.00%> (ø)
...ackages/bridge-ui/src/utils/switchEthereumChain.ts 100.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@d1onys1us d1onys1us marked this pull request as draft December 20, 2022 21:06
@vercel
Copy link

vercel bot commented Dec 21, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
website 🔄 Building (Inspect) Dec 21, 2022 at 0:06AM (UTC)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant