-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(test): making tests type-safe #318
Conversation
Codecov Report
@@ Coverage Diff @@
## main #318 +/- ##
==========================================
+ Coverage 64.08% 64.10% +0.01%
==========================================
Files 89 90 +1
Lines 2492 2524 +32
Branches 292 292
==========================================
+ Hits 1597 1618 +21
- Misses 828 834 +6
- Partials 67 72 +5
*This pull request uses carry forward flags. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
isMessageSent, isSignalReceived and isMessageReceived tests are done, waiting on @cyberhorsey to unblock retryMessage. Converted a bunch of tests to use type-chain for type safety. Please review! @dantaik @davidtaikocha |
We can do retryMessage in separate PR, to get this large opened one in when it is ready. |
@cyberhorsey implemented suggested changes, also made the signalProof generation into a util function (similarly repeatable) |
No description provided.