Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(protocol): use require-statements for readability #18325

Merged
merged 43 commits into from
Oct 30, 2024
Merged

chore(protocol): use require-statements for readability #18325

merged 43 commits into from
Oct 30, 2024

Conversation

dantaik
Copy link
Contributor

@dantaik dantaik commented Oct 28, 2024

No description provided.

dantaik and others added 28 commits October 25, 2024 14:53
@dantaik
set stateRoot for non-sync block to 0
8c99b9f
@dantaik
fix issue: M-01 Inconsistent Use of State Roots
ef7e98d
@dantaik
Update LibProving.sol
5dcac9e
@dantaik
Merge branch 'ontake_cleanup2' into fix_M-01-Inconsistent-Use-of-Stat…
56f241b 
…e-Roots
@dantaik
Merge branch 'ontake_cleanup2' into fix_M-01-Inconsistent-Use-of-Stat…
23bd5a4 
…e-Roots
@dantaik
Merge branch 'ontake_cleanup2' into fix_M-01-Inconsistent-Use-of-Stat…
a32978e 
…e-Roots
@dantaik
Merge branch 'ontake_cleanup2' into fix_M-01-Inconsistent-Use-of-Stat…
56d3508 
…e-Roots
@dantaik
Merge branch 'ontake_cleanup2' into fix_M-01-Inconsistent-Use-of-Stat…
81becaa 
…e-Roots
@dantaik
more
1a706b2
@dantaik
Update TaikoL1.sol
9760180
@dantaik
Update TaikoL1LibProvingWithTiers.t.sol
c4a254e
@dantaik
Merge branch 'ontake_cleanup2' into fix_M-01-Inconsistent-Use-of-Stat…
795272a 
…e-Roots
@dantaik
Merge branch 'ontake_cleanup2' into fix_M-01-Inconsistent-Use-of-Stat…
cdf258b 
…e-Roots
@dantaik
improve comments
be3384d
@dantaik
Update Multicall3.sol
25272d5
@dantaik
Revert "Update Multicall3.sol"
64b627d 
This reverts commit 25272d5.
@dantaik
Revert "improve comments"
1565b0c 
This reverts commit be3384d.
@dantaik
Merge branch 'ontake_cleanup2' into fix_M-01-Inconsistent-Use-of-Stat…
d01ae77 
…e-Roots
@dantaik
docs(protocol): improve Natspec comments (#18320)
3045429
@dantaik
Revert "docs(protocol): improve Natspec comments (#18320)"
73463f7 
This reverts commit 3045429.
@dantaik
Reapply "docs(protocol): improve Natspec comments (#18320)"
cda9bb5 
This reverts commit 73463f7.
@dantaik
Update LibUtils.sol
3423a32
@dantaik
Update LibProving.sol
a1d785f
@dantaik
Merge branch 'ontake_cleanup2' into redo_comment_improvement
104ff80
@dantaik
Merge branch 'ontake_cleanup2' into redo_comment_improvement
e319f73
@dantaik @RogerLamTd
Update packages/protocol/contracts/layer1/based/LibUtils.sol
9a9324e 
Co-authored-by: Roger <50648015+RogerLamTd@users.noreply.github.com>
@dantaik
minor fix
ff0bc66
@dantaik
use require-statements for readability
c6fa964
@openzeppelin-code OpenZeppelin Code
Copy link

openzeppelin-code bot commented Oct 28, 2024 •
edited
Loading

chore(protocol): use require-statements for readability

Generated at commit: 546b9a48603497c06d24e8f7fd0a05c0a792aa5d

🚨 Report Summary

Severity Level Results
Contracts Critical
High
Medium
Low
Note
Total		 3
3
0
7
42
55
Dependencies Critical
High
Medium
Low
Note
Total		 0
0
0
0
0
0

For more details view the full report in OpenZeppelin Code Inspector

@dantaik dantaik marked this pull request as ready for review October 28, 2024 07:43
@dantaik dantaik requested a review from davidtaikocha October 28, 2024 07:43
@dantaik dantaik closed this Oct 28, 2024
@dantaik dantaik reopened this Oct 28, 2024
@dantaik dantaik closed this Oct 29, 2024
@dantaik dantaik reopened this Oct 30, 2024
@dantaik dantaik added this pull request to the merge queue Oct 30, 2024
Merged via the queue into ontake_cleanup2 with commit 454d4b6 Oct 30, 2024
5 of 7 checks passed
@dantaik dantaik deleted the use_require branch October 30, 2024 02:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidtaikocha davidtaikocha davidtaikocha approved these changes

@YoGhurt111 YoGhurt111 YoGhurt111 approved these changes

Assignees
No one assigned
Labels
area.protocol
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dantaik @YoGhurt111 @davidtaikocha