refactor #17951
Merged
refactor #17951
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refactor
🚨 Report Summary
For more details view the full report in OpenZeppelin Code Inspector |
smtmfft
approved these changes
Aug 19, 2024
| /// @notice This contract is a verifier for the Mainnet ZkVM that composes RiscZero and SP1 | ||
| /// Verifiers. | ||
| /// @custom:security-contact security@taiko.xyz | ||
| contract ZkVMVerifier is ComposeVerifier { |
There was a problem hiding this comment.
Just think maybe also impl TEEVerifier in this PR since the framework code is exactly the same.
adaki2004
reviewed
Aug 20, 2024
Comment on lines
+43
to
+44
| for (uint256 i; i < verifiers.length; ++i) { | ||
| // Store the value 1 in the temporary storage slot using inline assembly |
There was a problem hiding this comment.
Should not we have a safeguard to not possibly reuse verifiers ? 🤔
Something like:
address prevVerifier;
for (uint256 i; i < verifiers.length; ++i) {
if (uint160(prevVerifier) >= uint160(verifiers[i])) {
revert L1_INVALID_VERIFIER();
}
...
prevVerifier = verifiers[i];
}
There was a problem hiding this comment.
The verifier is coded by us and is not dynamically configured by proposers/provers.
dantaik
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.