Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(protocol): use npm to manage third-party solidity dependency #17881

Merged
merged 3 commits into from
Aug 6, 2024
Merged

refactor(protocol): use npm to manage third-party solidity dependency #17881

merged 3 commits into from
Aug 6, 2024

Conversation

dantaik
Copy link
Contributor

@dantaik dantaik commented Aug 6, 2024

No description provided.

@dantaik dantaik marked this pull request as ready for review August 6, 2024 02:53
@dantaik dantaik marked this pull request as draft August 6, 2024 02:58
@openzeppelin-code OpenZeppelin Code
Copy link

openzeppelin-code bot commented Aug 6, 2024 •
edited
Loading

refactor(protocol): use solady's FixedPointMathLib

Generated at commit: f3fa16b380cd7bcadc5fe0ce682ea98b9875b22e

🚨 Report Summary

Severity Level Results
Contracts Critical
High
Medium
Low
Note
Total		 2
2
0
8
42
54
Dependencies Critical
High
Medium
Low
Note
Total		 0
0
0
0
0
0

For more details view the full report in OpenZeppelin Code Inspector

@dantaik dantaik changed the title refactor(protocol): use solady's FixedPointMathLib refactor(protocol): use npm to manage third-party solidity dependency Aug 6, 2024
@dantaik dantaik marked this pull request as ready for review August 6, 2024 03:26
@dantaik dantaik enabled auto-merge August 6, 2024 03:27
@dantaik dantaik added this pull request to the merge queue Aug 6, 2024
Merged via the queue into main with commit d524e69 Aug 6, 2024
6 checks passed
@dantaik dantaik deleted the FixedPointMathLib branch August 6, 2024 03:35
@taiko-kitty taiko-kitty mentioned this pull request Aug 6, 2024
Merged
This was referenced Sep 9, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YoGhurt111 YoGhurt111 YoGhurt111 approved these changes

@mask-pp mask-pp mask-pp approved these changes

@davidtaikocha davidtaikocha davidtaikocha approved these changes

@Brechtpd Brechtpd Awaiting requested review from Brechtpd

@adaki2004 adaki2004 Awaiting requested review from adaki2004

@smtmfft smtmfft Awaiting requested review from smtmfft

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dantaik @YoGhurt111 @mask-pp @davidtaikocha