Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(protocol): add withdraw eth function to proverset #17800

Merged
merged 5 commits into from
Jul 16, 2024
Merged

feat(protocol): add withdraw eth function to proverset #17800

merged 5 commits into from
Jul 16, 2024

Conversation

RogerLamTd
Copy link
Contributor

ref #17784

@RogerLamTd RogerLamTd self-assigned this Jul 16, 2024
@openzeppelin-code OpenZeppelin Code
Copy link

openzeppelin-code bot commented Jul 16, 2024 •
edited
Loading

feat(protocol): add withdraw eth function to proverset

Generated at commit: df760a9570434fd6ca6ff4b58085b8f298501d25

🚨 Report Summary

Severity Level Results
Contracts Critical
High
Medium
Low
Note
Total		 2
2
0
8
42
54
Dependencies Critical
High
Medium
Low
Note
Total		 0
0
0
0
0
0

For more details view the full report in OpenZeppelin Code Inspector

RogerLamTd and others added 2 commits July 15, 2024 22:40
@RogerLamTd @dantaik
Update packages/protocol/contracts/team/proving/ProverSet.sol
239d631 
Co-authored-by: Daniel Wang <99078276+dantaik@users.noreply.github.com>
@RogerLamTd
apply comments
f122bf7
@RogerLamTd RogerLamTd requested a review from dantaik July 16, 2024 05:51
@RogerLamTd RogerLamTd requested a review from dantaik July 16, 2024 14:05
@RogerLamTd RogerLamTd added this pull request to the merge queue Jul 16, 2024
Merged via the queue into main with commit bb2abc5 Jul 16, 2024
5 checks passed
@RogerLamTd RogerLamTd deleted the add-withdraw branch July 16, 2024 14:38
@taiko-kitty taiko-kitty mentioned this pull request Jul 16, 2024
Merged
@davidtaikocha davidtaikocha mentioned this pull request Jul 17, 2024
Closed
1 task
This was referenced Sep 9, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dantaik dantaik dantaik approved these changes

@davidtaikocha davidtaikocha davidtaikocha approved these changes

@d1onys1us d1onys1us Awaiting requested review from d1onys1us

@adaki2004 adaki2004 Awaiting requested review from adaki2004

Assignees

@RogerLamTd RogerLamTd

Labels
area.protocol
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RogerLamTd @dantaik @davidtaikocha