Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(protocol): allow GuardianProver set TKO allowance for TaikoL1 #16831

Merged
merged 5 commits into from
Apr 25, 2024
Merged

feat(protocol): allow GuardianProver set TKO allowance for TaikoL1 #16831

merged 5 commits into from
Apr 25, 2024

Conversation

dantaik
Copy link
Contributor

@dantaik dantaik commented Apr 24, 2024 •
edited
Loading

When GuardianProver's tier is TIER_GUARDIAN_MINORITY, it will need to place validity bond by holding TKO and allow the TaikoL1 contract to transfer TKO out.

@davidtaikocha if we deploy GuardianProver for tier TIER_GUARDIAN_MINORITY, we should call enableTaikoTokenAllowance(true) on it.

@dantaik dantaik marked this pull request as ready for review April 24, 2024 15:25
@dantaik dantaik enabled auto-merge April 24, 2024 15:26
@davidtaikocha @dantaik
feat(protocol): do not deploy AddressManager anymore in `DeployTaikoT…
fc74078 
…oken.s.sol` (#16828)

Co-authored-by: Daniel Wang <99078276+dantaik@users.noreply.github.com>
@openzeppelin-code OpenZeppelin Code
Copy link

openzeppelin-code bot commented Apr 24, 2024 •
edited
Loading

feat(protocol): allow GuardianProver set TKO allowance for TaikoL1

Generated at commit: d85c9869a4b24e131ed446d05bbb3375f676bfe6

🚨 Report Summary

Severity Level Results
Contracts Critical
High
Medium
Low
Note
Total		 2
2
0
6
40
50
Dependencies Critical
High
Medium
Low
Note
Total		 0
0
0
0
0
0

For more details view the full report in OpenZeppelin Code Inspector

@dantaik dantaik added this pull request to the merge queue Apr 25, 2024
Merged via the queue into main with commit ce7076c Apr 25, 2024
7 checks passed
@dantaik dantaik deleted the guardian_prover_set_allowance branch April 25, 2024 00:53
This was referenced Apr 24, 2024
Merged
Closed
@taiko-kitty taiko-kitty mentioned this pull request May 11, 2024
Closed
@taiko-kitty taiko-kitty mentioned this pull request Jun 14, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Brechtpd Brechtpd Brechtpd approved these changes

@davidtaikocha davidtaikocha davidtaikocha approved these changes

Assignees
No one assigned
Labels
area.protocol
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dantaik @Brechtpd @davidtaikocha