Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bridge-ui): custom and none fee selection overwritten by error fetching recommended fee #16737

Merged
merged 2 commits into from
Apr 16, 2024

Conversation

CodeDragonVN
Copy link
Contributor

When there's an error calculating the recommended fee, the label Error calculating processing fee, you will need to claim manually! replaces the value of custom and none fees when these are selected instead of the Recommended fee.

Regardless of the fee type selected, the error message will show up next to the 'Processing Fee' text:
processingfee

With my fix, when selecting a custom fee or none fee, the selected fee amount shows accuratly:

Description Screenshot
When None fee is selected None fee selected
When a custom is selected Custom fee selected

Copy link

vercel bot commented Apr 15, 2024

@CodeDragonVN is attempting to deploy a commit to the taikoxyz Team on Vercel.

A member of the Team first needs to authorize it.

@KorbinianK
Copy link
Contributor

@CodeDragonVN the main branch is not considered to be stable yet and this error does not appear on the deployed version of Katla. But it is a bug regardless and I appreciate your input and staying up to date on the changes.

Please fix the linting issues in order to get this merged.

@KorbinianK KorbinianK self-assigned this Apr 15, 2024
@davidtaikocha davidtaikocha added this pull request to the merge queue Apr 16, 2024
Merged via the queue into taikoxyz:main with commit 9166ee3 Apr 16, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants