Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(protocol): add various small fixes based on quill report #16031

Merged
merged 9 commits into from
Feb 24, 2024
Merged

feat(protocol): add various small fixes based on quill report #16031

merged 9 commits into from
Feb 24, 2024

Conversation

dantaik
Copy link
Contributor

@dantaik dantaik commented Feb 24, 2024 •
edited
Loading

No description provided.

@dantaik dantaik changed the title chore(protocol): check addresses not same chore(protocol): add various small fixes based on quill report Feb 24, 2024
@dantaik dantaik marked this pull request as ready for review February 24, 2024 03:15
@d1onys1us
Copy link
Contributor

this looks like a backwards compatible feature, not a chore. so we can do feat(protocol): *. chore(*):* items will not get added to our CHANGELOG.

@dantaik dantaik changed the title chore(protocol): add various small fixes based on quill report feat(protocol): add various small fixes based on quill report Feb 24, 2024
@dantaik dantaik removed the request for review from davidtaikocha February 24, 2024 14:33
@dantaik dantaik added this pull request to the merge queue Feb 24, 2024
Merged via the queue into main with commit 1f46b33 Feb 24, 2024
6 checks passed
@dantaik dantaik deleted the check_addresses_not_same branch February 24, 2024 14:52
This was referenced Feb 24, 2024
Merged
Closed
@taiko-kitty taiko-kitty mentioned this pull request Mar 29, 2024
Closed
This was referenced Apr 5, 2024
Closed
Closed
@taiko-kitty taiko-kitty mentioned this pull request Apr 25, 2024
Closed
@taiko-kitty taiko-kitty mentioned this pull request May 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Brechtpd Brechtpd Brechtpd approved these changes

@adaki2004 adaki2004 adaki2004 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dantaik @d1onys1us @Brechtpd @adaki2004