Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(protocol): need to fix a bug in LibTrieProof (or its test) #15739

Merged
merged 7 commits into from
Feb 11, 2024
Merged

fix(protocol): need to fix a bug in LibTrieProof (or its test) #15739

merged 7 commits into from
Feb 11, 2024

Conversation

dantaik
Copy link
Contributor

@dantaik dantaik commented Feb 11, 2024

forge test --evm-version cancun -vvv --mt test_verifyFullMerkleProof fails

@dantaik dantaik assigned dantaik and adaki2004 and unassigned dantaik Feb 11, 2024
@dantaik dantaik requested a review from adaki2004 February 11, 2024 14:26
@adaki2004 adaki2004 marked this pull request as ready for review February 11, 2024 15:39
@adaki2004
Copy link
Contributor

Issue was padding:
bytes.concat(value)

In previous code we simply passed the hex"01" to SecureMerkleTrie but now it went through an intermediary call (from SignalService -> LibTrieProof -> SecureMerkleTrie and the conversion + bytes.concat padded it like this:
0x0100000000000000000000000000000000000000000000000000000000000000
but we need this:
0x01

@adaki2004 adaki2004 requested a review from Brechtpd February 11, 2024 15:42
@Brechtpd Brechtpd merged commit ac1ca31 into main Feb 11, 2024
14 checks passed
@Brechtpd Brechtpd deleted the to_fix_pending_bug branch February 11, 2024 17:46
@github-actions github-actions bot mentioned this pull request Feb 11, 2024
Merged
@taiko-kitty taiko-kitty mentioned this pull request Mar 1, 2024
Closed
@taiko-kitty taiko-kitty mentioned this pull request Mar 29, 2024
Closed
This was referenced Apr 5, 2024
Closed
Closed
@taiko-kitty taiko-kitty mentioned this pull request Apr 25, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adaki2004 adaki2004 adaki2004 approved these changes

@Brechtpd Brechtpd Brechtpd approved these changes

Assignees

@adaki2004 adaki2004

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dantaik @adaki2004 @Brechtpd