Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(protocol): fix signal service multi-hop proof verification bugs #15680

Merged
merged 98 commits into from
Feb 10, 2024
Merged

feat(protocol): fix signal service multi-hop proof verification bugs #15680

merged 98 commits into from
Feb 10, 2024

Commits on Feb 5, 2024

  1. breaking change by removing signal service overhead

    @dantaik
    dantaik committed Feb 5, 2024
    Configuration menu
    Copy the full SHA
    ab12a57 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'alpha-6' into alpha-7

    @dantaik
    dantaik committed Feb 5, 2024
    Configuration menu
    Copy the full SHA
    3744fc8 View commit details
    Browse the repository at this point in the history

Commits on Feb 6, 2024

  1. Merge branch 'alpha-6' into alpha-7

    @dantaik
    dantaik committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    b5728d1 View commit details
    Browse the repository at this point in the history

Commits on Feb 7, 2024

  1. remove signalRoot step 1

    @dantaik
    dantaik committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    a0f5efb View commit details
    Browse the repository at this point in the history

  2. Update LibProving.sol

    @dantaik
    dantaik committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    019ef54 View commit details
    Browse the repository at this point in the history

  3. more

    @dantaik
    dantaik committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    45e8ceb View commit details
    Browse the repository at this point in the history

  4. Update LibUtils.sol

    @dantaik
    dantaik committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    9224460 View commit details
    Browse the repository at this point in the history

  5. Update LibVerifying.sol

    @dantaik
    dantaik committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    758ab07 View commit details
    Browse the repository at this point in the history

  6. more

    @dantaik
    dantaik committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    71396f4 View commit details
    Browse the repository at this point in the history

  7. Update TaikoL2.sol

    @dantaik
    dantaik committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    5aa18f5 View commit details
    Browse the repository at this point in the history

  8. Update TaikoL2.sol

    @dantaik
    dantaik committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    b050af5 View commit details
    Browse the repository at this point in the history

  9. Update TaikoL2.sol

    @dantaik
    dantaik committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    f978d83 View commit details
    Browse the repository at this point in the history

  10. Make code compiling

    Keszey Dániel authored and Keszey Dániel committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    7f48859 View commit details
    Browse the repository at this point in the history

  11. Add back helpers and uncomment lines

    Keszey Dániel authored and Keszey Dániel committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    ed3d47c View commit details
    Browse the repository at this point in the history

  12. fix anchor

    @dantaik
    dantaik committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    d6def2a View commit details
    Browse the repository at this point in the history

  13. Update TaikoL2.sol

    @dantaik
    dantaik committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    27de76a View commit details
    Browse the repository at this point in the history

  14. Update TaikoL2.t.sol

    @dantaik
    dantaik committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    05dd063 View commit details
    Browse the repository at this point in the history

  15. minor

    @dantaik
    dantaik committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    2e22f3e View commit details
    Browse the repository at this point in the history

  16. rename

    @dantaik
    dantaik committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    28134d6 View commit details
    Browse the repository at this point in the history

  17. rename

    @dantaik
    dantaik committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    1e70e33 View commit details
    Browse the repository at this point in the history

  18. update multi-hop bridging diagrams

    @dantaik
    dantaik committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    425be15 View commit details
    Browse the repository at this point in the history

  19. more error messages in signal service

    @dantaik
    dantaik committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    7a2d7f2 View commit details
    Browse the repository at this point in the history

  20. Update SignalService.sol

    @dantaik
    dantaik committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    0a809f9 View commit details
    Browse the repository at this point in the history

  21. Update SignalService.sol

    @dantaik
    dantaik committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    27f51d3 View commit details
    Browse the repository at this point in the history

  22. Update SignalService.sol

    @dantaik
    dantaik committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    2bd445b View commit details
    Browse the repository at this point in the history

  23. Update SignalService.sol

    @dantaik
    dantaik committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    8200313 View commit details
    Browse the repository at this point in the history

  24. comments

    @dantaik
    dantaik committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    9ded143 View commit details
    Browse the repository at this point in the history

  25. Update LibVerifying.sol

    @dantaik
    dantaik committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    bef6290 View commit details
    Browse the repository at this point in the history

  26. more

    @dantaik
    dantaik committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    c6e72ff View commit details
    Browse the repository at this point in the history

  27. Update TaikoL2.sol

    @dantaik
    dantaik committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    528288d View commit details
    Browse the repository at this point in the history

  28. more

    @dantaik
    dantaik committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    f8986e4 View commit details
    Browse the repository at this point in the history

  29. more

    @dantaik
    dantaik committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    13e3f1f View commit details
    Browse the repository at this point in the history

  30. remove unnecessary resolve

    Keszey Dániel authored and Keszey Dániel committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    70a26a4 View commit details
    Browse the repository at this point in the history

Commits on Feb 8, 2024

  1. remove LibBlockHeader

    @dantaik
    dantaik committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    4ad3781 View commit details
    Browse the repository at this point in the history

  2. Delete RLPWriter.sol

    @dantaik
    dantaik committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    5059135 View commit details
    Browse the repository at this point in the history

  3. more

    @dantaik
    dantaik committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    3abba11 View commit details
    Browse the repository at this point in the history

  4. more

    @dantaik
    dantaik committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    c292c4d View commit details
    Browse the repository at this point in the history

  5. Remove mint

    @dantaik
    dantaik committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    7ead006 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'alpha-7' into remove-signal-root

    @dantaik
    dantaik committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    dbd15c5 View commit details
    Browse the repository at this point in the history

  7. Merge branch 'remove-signal-root' into fix-multi-hop-trust-graph-issue

    @dantaik
    dantaik committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    8cc3469 View commit details
    Browse the repository at this point in the history

  8. more

    @dantaik
    dantaik committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    30db4aa View commit details
    Browse the repository at this point in the history

  9. more

    @dantaik
    dantaik committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    cede345 View commit details
    Browse the repository at this point in the history

  10. Update SignalService.sol

    @dantaik
    dantaik committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    8eaf042 View commit details
    Browse the repository at this point in the history

  11. more

    @dantaik
    dantaik committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    0fc2c39 View commit details
    Browse the repository at this point in the history

  12. Update MultihopGraph.sol

    @dantaik
    dantaik committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    7bfe4c0 View commit details
    Browse the repository at this point in the history

  13. Update SignalService.sol

    @dantaik
    dantaik committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    45ed3e5 View commit details
    Browse the repository at this point in the history

  14. Update SignalService.sol

    @dantaik
    dantaik committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    3c78fb8 View commit details
    Browse the repository at this point in the history

  15. Update MultihopGraph.sol

    @dantaik
    dantaik committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    f76d680 View commit details
    Browse the repository at this point in the history

  16. Update MultihopGraph.sol

    @dantaik
    dantaik committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    d2ee9b5 View commit details
    Browse the repository at this point in the history

  17. Merge branch 'alpha-6' into alpha-7

    @dantaik
    dantaik committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    0821cad View commit details
    Browse the repository at this point in the history

  18. Update MultiHopGraph.sol

    @dantaik
    dantaik committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    f2cdc30 View commit details
    Browse the repository at this point in the history

  19. more

    @dantaik
    dantaik committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    b28c832 View commit details
    Browse the repository at this point in the history

  20. Merge branch 'alpha-6' into alpha-7

    @dantaik
    dantaik committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    9f3c136 View commit details
    Browse the repository at this point in the history

  21. Merge branch 'alpha-7' into remove-signal-root

    @dantaik
    dantaik committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    b86f7c5 View commit details
    Browse the repository at this point in the history

  22. Merge branch 'remove-signal-root' into fix-multi-hop-trust-graph-issue

    @dantaik
    dantaik committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    cae97d3 View commit details
    Browse the repository at this point in the history

  23. Delete AuthorizableContract.t.sol

    @dantaik
    dantaik committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    d98614b View commit details
    Browse the repository at this point in the history

  24. more

    @dantaik
    dantaik committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    ac07d4a View commit details
    Browse the repository at this point in the history

  25. fix tests

    @dantaik
    dantaik committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    911c424 View commit details
    Browse the repository at this point in the history

  26. fix tests

    @dantaik
    dantaik committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    92066ab View commit details
    Browse the repository at this point in the history

  27. Merge branch 'remove-signal-root' into fix-multi-hop-trust-graph-issue

    @dantaik
    dantaik committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    b9d264c View commit details
    Browse the repository at this point in the history

  28. Update TaikoData.sol

    @dantaik
    dantaik committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    5adc75c View commit details
    Browse the repository at this point in the history

  29. rename

    @dantaik
    dantaik committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    df57594 View commit details
    Browse the repository at this point in the history

  30. Update SignalService.t.sol

    @dantaik
    dantaik committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    41220d0 View commit details
    Browse the repository at this point in the history

  31. more

    @dantaik
    dantaik committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    11a0a8a View commit details
    Browse the repository at this point in the history

  32. more

    @dantaik
    dantaik committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    3cfaf13 View commit details
    Browse the repository at this point in the history

  33. more

    @dantaik
    dantaik committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    a090455 View commit details
    Browse the repository at this point in the history

Commits on Feb 9, 2024

  1. Merge branch 'main' into remove-signal-root

    @dantaik
    dantaik committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    458234a View commit details
    Browse the repository at this point in the history

  2. Update TaikoToken.sol

    @dantaik
    dantaik committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    4f12970 View commit details
    Browse the repository at this point in the history

  3. fix

    @dantaik
    dantaik committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    67b9e4f View commit details
    Browse the repository at this point in the history

  4. Update SignalService.sol

    @dantaik
    dantaik committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    233f712 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'remove-signal-root' into fix-multi-hop-trust-graph-issue

    @dantaik
    dantaik committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    5b46768 View commit details
    Browse the repository at this point in the history

  6. fix

    @dantaik
    dantaik committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    101a2e5 View commit details
    Browse the repository at this point in the history

  7. more

    @dantaik
    dantaik committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    e3be732 View commit details
    Browse the repository at this point in the history

  8. Update SignalService.sol

    @dantaik
    dantaik committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    fb0128a View commit details
    Browse the repository at this point in the history

  9. more

    @dantaik
    dantaik committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    1eac276 View commit details
    Browse the repository at this point in the history

  10. more

    @dantaik
    dantaik committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    6c6b9d7 View commit details
    Browse the repository at this point in the history

  11. fmt

    @dantaik
    dantaik committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    2227678 View commit details
    Browse the repository at this point in the history

  12. doc

    @dantaik
    dantaik committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    03468a0 View commit details
    Browse the repository at this point in the history

  13. Update SignalService.sol

    @dantaik
    dantaik committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    0b2069c View commit details
    Browse the repository at this point in the history

  14. add one test

    @dantaik
    dantaik committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    84fc2ae View commit details
    Browse the repository at this point in the history

  15. reserve 2 slots for TaikoData.Transition

    @dantaik
    dantaik committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    52147b3 View commit details
    Browse the repository at this point in the history

  16. Revert "reserve 2 slots for TaikoData.Transition" 

    This reverts commit 52147b3.
    @dantaik
    dantaik committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    08c0ae2 View commit details
    Browse the repository at this point in the history

  17. fmt

    @dantaik
    dantaik committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    0ed00af View commit details
    Browse the repository at this point in the history

  18. Merge branch 'remove-signal-root' into fix-multi-hop-trust-graph-issue

    @dantaik
    dantaik committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    1ad9404 View commit details
    Browse the repository at this point in the history

  19. fix

    @dantaik
    dantaik committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    538b2ab View commit details
    Browse the repository at this point in the history

  20. Update taikoL2.ts

    @dantaik
    dantaik committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    d19ac48 View commit details
    Browse the repository at this point in the history

  21. Merge branch 'main' into remove-signal-root

    @dantaik
    dantaik committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    2826b17 View commit details
    Browse the repository at this point in the history

  22. Merge branch 'remove-signal-root' into fix-multi-hop-trust-graph-issue

    @dantaik
    dantaik committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    5a4dd4a View commit details
    Browse the repository at this point in the history

  23. fix comment

    @dantaik
    dantaik committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    f73c33a View commit details
    Browse the repository at this point in the history

  24. Update packages/protocol/contracts/L1/TaikoL1.sol 

    Co-authored-by: Brecht Devos <Brechtp.Devos@gmail.com>
    @dantaik @Brechtpd
    dantaik and Brechtpd committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    238f8a4 View commit details
    Browse the repository at this point in the history

  25. Update packages/protocol/contracts/signal/SignalService.sol 

    Co-authored-by: Brecht Devos <Brechtp.Devos@gmail.com>
    @dantaik @Brechtpd
    dantaik and Brechtpd committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    93869d9 View commit details
    Browse the repository at this point in the history

  26. Update packages/protocol/contracts/L2/TaikoL2.sol 

    Co-authored-by: Brecht Devos <Brechtp.Devos@gmail.com>
    @dantaik @Brechtpd
    dantaik and Brechtpd committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    57b73c5 View commit details
    Browse the repository at this point in the history

  27. Update packages/protocol/contracts/signal/SignalService.sol 

    Co-authored-by: Brecht Devos <Brechtp.Devos@gmail.com>
    @dantaik @Brechtpd
    dantaik and Brechtpd committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    298bd20 View commit details
    Browse the repository at this point in the history

  28. Update PseZkVerifier.sol

    @dantaik
    dantaik committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    c0b39c8 View commit details
    Browse the repository at this point in the history

Commits on Feb 10, 2024

  1. Merge branch 'main' into remove-signal-root

    @dantaik
    dantaik committed Feb 10, 2024
    Configuration menu
    Copy the full SHA
    a2771e7 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'remove-signal-root' into fix-multi-hop-trust-graph-issue

    @dantaik
    dantaik committed Feb 10, 2024
    Configuration menu
    Copy the full SHA
    f9d0b26 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into fix-multi-hop-trust-graph-issue

    @dantaik
    dantaik committed Feb 10, 2024
    Configuration menu
    Copy the full SHA
    76fef95 View commit details
    Browse the repository at this point in the history

  4. fix merge

    @dantaik
    dantaik committed Feb 10, 2024
    Configuration menu
    Copy the full SHA
    319dc9e View commit details
    Browse the repository at this point in the history