Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(protocol): address miscellaneous feedbacks from Sigma Prime (TKO26) #15600

Merged
merged 11 commits into from
Jan 30, 2024
8 changes: 3 additions & 5 deletions packages/protocol/contracts/L1/TaikoErrors.sol
Original file line number Diff line number Diff line change
Expand Up @@ -27,10 +27,8 @@ abstract contract TaikoErrors {
error L1_BLOB_FOR_DA_DISABLED();
error L1_BLOB_NOT_FOUND();
error L1_BLOB_NOT_REUSEABLE();
error L1_BLOB_NOT_USED();
error L1_BLOCK_MISMATCH();
error L1_INSUFFICIENT_TOKEN();
error L1_INVALID_ADDRESS();
error L1_INVALID_AMOUNT();
error L1_INVALID_BLOCK_ID();
error L1_INVALID_CONFIG();
error L1_INVALID_ETH_DEPOSIT();
Expand All @@ -46,12 +44,12 @@ abstract contract TaikoErrors {
error L1_PROPOSER_NOT_EOA();
error L1_PROVING_PAUSED();
error L1_RECEIVE_DISABLED();
error L1_MISSING_VERIFIER();
error L1_TOO_MANY_BLOCKS();
error L1_TOO_MANY_TIERS();
error L1_TRANSITION_ID_ZERO();
error L1_TRANSITION_NOT_FOUND();
error L1_TXLIST_OFFSET_SIZE();
error L1_TXLIST_TOO_LARGE();
error L1_TXLIST_SIZE();
error L1_UNAUTHORIZED();
error L1_UNEXPECTED_PARENT();
error L1_UNEXPECTED_TRANSITION_ID();
Expand Down
14 changes: 0 additions & 14 deletions packages/protocol/contracts/L1/TaikoEvents.sol
Original file line number Diff line number Diff line change
Expand Up @@ -84,18 +84,4 @@ abstract contract TaikoEvents {
/// @param deposit The Ethereum deposit information including recipient,
/// amount, and ID.
event EthDeposited(TaikoData.EthDeposit deposit);

/// @dev Emitted when a user deposited Taiko token into this contract.
event TokenDeposited(uint256 amount);

/// @dev Emitted when a user withdrawed Taiko token from this contract.
event TokenWithdrawn(uint256 amount);

/// @dev Emitted when Taiko token are credited to the user's in-protocol
/// balance.
event TokenCredited(address to, uint256 amount);

/// @dev Emitted when Taiko token are debited from the user's in-protocol
/// balance.
event TokenDebited(address from, uint256 amount);
}
2 changes: 1 addition & 1 deletion packages/protocol/contracts/L1/TaikoL1.sol
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ pragma solidity 0.8.24;
import "../common/EssentialContract.sol";
import "./libs/LibDepositing.sol";
import "./libs/LibProposing.sol";
// import "./libs/LibProving.sol";
//import "./libs/LibProving.sol";
import { LibProvingAlt as LibProving } from "./libs/LibProvingAlt.sol";
import "./libs/LibVerifying.sol";
import "./ITaikoL1.sol";
Expand Down
Loading
Loading