Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(protocol): refactor bridge/vault/signal for multi-chain deployment #15061

Merged
merged 204 commits into from
Nov 15, 2023

Conversation

dantaik
Copy link
Contributor

@dantaik dantaik commented Oct 27, 2023

The following major changes are included in this PR:

  • refactored token vault contracts, now they have a common base to handle interaction with the Bridge contract.
  • Bridge contract and token vaults no longer check the to address, it will handled on the destination bridge/vault without failure.
  • Bridge allows message.to to be a TaikoL1 contract address.
  • Merged EtherVault into Bridge to simplify deployment
  • Added a AuthorizableContract contract.
  • SignalService is now an AuthorizableContract contract.
  • New contract owner must claim the ownership.
  • Allow owner to pause proving/verifying blocks.
  • Ensure proposer is EOA when use calldata for DA (otherwise it's hard for client to download the calldata)
  • Ensure chain ID is a uint64 so it can be made part of the address of each pre-deployment contract.
  • SignalService's proof need to have an crossChainSync address.

After this PR: multihop bridging shall be truly enabled. The relayer needs to be modified accordingly, @cyberhorsey :

All reviewers, please read:

Read this: https://github.com/taikoxyz/taiko-mono/blob/bridgable_app/packages/protocol/docs/multihop_bridging_deployment.md

If you have questions, please DM me in discord to schedule a zoom call ASAP!

Co-authored-by: Daniel Wang <dong77@gmail.com>
Co-authored-by: Daniel Wang <dong77@gmail.com>
Co-authored-by: Daniel Wang <dong77@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants