feat(website): Update node troubleshooting for Windows users. #14032
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a command line to the clone simple-taiko-node section to prevent errors when running the Taiko node on Windows, and added leppaludi's nice description to the troubleshooting section.
chore(website,repo): add integration guide and update add to project …
davidtaikocha
previously approved these changes
Jun 22, 2023
dionysuzx
reviewed
Jun 22, 2023
dionysuzx
reviewed
Jun 22, 2023
|
hi @ikaika1 i left some small comments. otherwise looks great, thanks! |
I will commit the proposed changes. Co-authored-by: dave | d1onys1us <13951458+d1onys1us@users.noreply.github.com>
I will commit the proposed changes. Co-authored-by: dave | d1onys1us <13951458+d1onys1us@users.noreply.github.com>
dionysuzx
previously approved these changes
Jun 23, 2023
|
I see the following issues with tabs
|
MarcusWentz
suggested changes
Jun 23, 2023
There was a problem hiding this comment.
Please fix
#14032 (comment)
I think you just need a closing Tab tag.
I have added one missing </Tab> to the text.
auto-merge was automatically disabled
June 23, 2023 21:38
Head branch was pushed to by a user without write access
I have added the missing ``` to the code.
2manslkh
approved these changes
Jun 24, 2023
MarcusWentz
approved these changes
Jun 24, 2023
|
Congrats, your important contribution to this open-source project has earned you a GitPOAP! GitPOAP: 2023 Taiko Contributor: Head to gitpoap.io & connect your GitHub account to mint! Learn more about GitPOAPs here. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: When trying to run a node on Windows, an error occurs - simple-taiko-node-taiko_client_prover_relayer-1 | /bin/sh:/script/start-prover-relayer.sh:not found.
Fix: Updated steps in docs so that no errors occur when running a node on Windows and added leppaludi's nice suggested fix in the troubleshooting section of the docs.