-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(protocol): update Alpha-3 protocol configurations #13806
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because each proof has the exact same cost currently, I think we should make it so the prover fee cannot change quickly (tweak adjustmentQuotient
).
What average block time will we use / assume for A3? (3 seconds?)
Very important this matches the proposing EIP-1559 target!
Do we need to increase the cooldown period for A3 network? (
I don't know how stable Sepolia is, but if things generally work well and we're confident we can get these overwrite transactions in fast enough then seems ok to me.
What param1559.gasIssuedPerSecond will we use? (i think it depends on the avg block time that we predict)
EDIT: I confused this value with gasExcess
.
Shall we change param1559.yscale / param1559.xscale / param1559.gasExcess?
See comment on this above.
Shall we make sure state.blockFee always >=1? (to prevent proposing becomes "totally free"?)
If the proposing EIP-1559 parameters are set well, I don't think this will be necessary (could be a big IF)
Unfortunately not so easy to find all the correct values here because some manual tweaking necessary in the helper script which I haven't tried to do. Something easier and fully automatic like https://github.com/taikoxyz/taiko-mono/blob/main/packages/protocol/script/DetermineNewProofTimeIssued.s.sol + some input parameter simplification #13556 like with the proving fee would certainly help to make this easier to configure! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have we seen the proposal basefee work within reasonable ranges on our internal testnet?
In current internal devnet, all provers will at least wait |
Ah yeah I heard about that! It looks like how I name things is a bit confusing, what about the L2 basefee that the proposer pays on L2? That one also depends on proposing blocks at fixed intervals (same as with the proofs) to keep the basefee steady. So was wondering if the behavior there was as expected and we can for sure push that L2 basefee pretty high in a small amount of time (we need that high L2 basefee to prevent spam). |
@davidtaikocha @Brechtpd @adaki2004 Do you think we should get onto a call to quickly resolve this issue? |
after upgrade the proxy implementation and use Dani's new params:
seems the fee backs to stable again at least for last hour. and before that, our client sometimes will submit the proofs asap, and zkpool's client also always submits proof asap, i think this is also part of the reason. |
And im ok for a call to do the final overall checking of this PR. |
…)" This reverts commit d3560d8.
Duplicate of # |
update-alpha-3-configs |
Questions to discuss:
minEthDepositAmount
to 0.1 ETHs? (some concerns here) => should be fineproofCooldownPeriod
+systemProofCooldownPeriod
) => if Sepolia generally work well and we're confident we can get these overwrite transactions in fast enough then seems ok.realProofSkipSize
? (i think it depends on the avg block time that we predict) => start with realProofSkipSize: 10 for the initial wave, we can reconsider afterwardstreasury
address will we use? =>0xdf09A0afD09a63fb04ab3573922437e1e637dE8b
INITIAL_PROOF_TIME_TARGET
will we use? (in current internal devnet, avg proof submission time is ~80s, so shall we use120s
? if we use120s
, theninitProofTimeIssued
will be49883
) =>2 * 80 (avg proof submission time) = 160
param1559.gasIssuedPerSecond
will we use? (i think it depends on the avg block time that we predict) => param1559.gasIssuedPerSecond := 2,000,000 gas/s == 4 L2 blocks of 6M gas/L1 blockparam1559.yscale
/param1559.xscale
/param1559.gasExcess
? => lets calculate them in TaikoL2's init() functionstate.blockFee
always>=1
? (to prevent proposing becomes "totally free"?) => If the proposing EIP-1559 parameters are set well, seems this will be unnecessary (could be a big IF)