Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(protocol): add a markdown to document how blocks are proven #13750

Merged
merged 55 commits into from
May 22, 2023

Conversation

dantaik
Copy link
Contributor

@dantaik dantaik commented May 13, 2023

Dani, please view the file on github using this link:https://github.com/taikoxyz/taiko-mono/blob/2ab1dd16fc708b2559ae400f0a7567dfb147bd5d/packages/protocol/docs/ZKReq.md (the link may change if you edit the file).

Please migrate our internal doc into this file and update the diagram accordingly. The diagram is partially incorrect as many suggestions in your commented PDF file are not incorporated. I'll leave this PR to you.

When this PR is ready, please ask Brecht, Yue, David, and Jeff for review.

@dantaik dantaik requested review from johntaiko and removed request for johntaiko May 22, 2023 07:42
Co-authored-by: dantaik <dantaik@users.noreply.github.com>
davidtaikocha
davidtaikocha previously approved these changes May 22, 2023
adaki2004
adaki2004 previously approved these changes May 22, 2023
Brechtpd
Brechtpd previously approved these changes May 22, 2023
Co-authored-by: David <david@taiko.xyz>
@dantaik dantaik added this pull request to the merge queue May 22, 2023
Merged via the queue into main with commit 8aa0940 May 22, 2023
@dantaik dantaik deleted the prover_req_diagram branch May 22, 2023 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants