-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(protocol): add a markdown to document how blocks are proven #13750
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dantaik
changed the title
add ZKReq.html
docs(protocol): add a markdown to document how blocks are proven
May 13, 2023
Co-authored-by: dantaik <dantaik@users.noreply.github.com>
davidtaikocha
previously approved these changes
May 22, 2023
adaki2004
previously approved these changes
May 22, 2023
Brechtpd
previously approved these changes
May 22, 2023
Co-authored-by: David <david@taiko.xyz>
dantaik
dismissed stale reviews from Brechtpd, adaki2004, and davidtaikocha
via
May 22, 2023 14:34
6b86689
davidtaikocha
approved these changes
May 22, 2023
Brechtpd
approved these changes
May 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dani, please view the file on github using this link:https://github.com/taikoxyz/taiko-mono/blob/2ab1dd16fc708b2559ae400f0a7567dfb147bd5d/packages/protocol/docs/ZKReq.md (the link may change if you edit the file).
Please migrate our internal doc into this file and update the diagram accordingly. The diagram is partially incorrect as many suggestions in your commented PDF file are not incorporated. I'll leave this PR to you.
When this PR is ready, please ask Brecht, Yue, David, and Jeff for review.