Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(protocol): Deploy a FreeMintERC20 and a MayFailFreeMintERC20 on deploy of L1 #13222

Merged
merged 2 commits into from
Feb 28, 2023

Conversation

cyberhorsey
Copy link
Contributor

@cyberhorsey cyberhorsey commented Feb 27, 2023

We need two tokens for testnet which we can mint in the bridge faucet: one is the ERC20 which should always succeed, and the none which should maybe fail, so we can test releaseTokens functionality.

I made these more generic so we can change names/etc per testnet without chaning contracts, or deploy multiple of them easily.

@cyberhorsey cyberhorsey changed the title feat(protocl): Deploy a FreeMintERC20 and a MayFailFreeMintERC20 on deploy of L1 feat(protocol): Deploy a FreeMintERC20 and a MayFailFreeMintERC20 on deploy of L1 Feb 27, 2023
@codecov
Copy link

codecov bot commented Feb 27, 2023

Codecov Report

Merging #13222 (65672d5) into main (72f9c1d) will decrease coverage by 0.07%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main   #13222      +/-   ##
==========================================
- Coverage   60.72%   60.65%   -0.07%     
==========================================
  Files         116      117       +1     
  Lines        3524     3528       +4     
  Branches      483      483              
==========================================
  Hits         2140     2140              
- Misses       1300     1304       +4     
  Partials       84       84              
Flag Coverage Δ *Carryforward flag
bridge-ui 93.80% <ø> (ø) Carriedforward from 72f9c1d
protocol 50.91% <0.00%> (-0.11%) ⬇️
relayer 65.15% <ø> (ø) Carriedforward from 72f9c1d
ui 100.00% <ø> (ø) Carriedforward from 72f9c1d

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...es/protocol/contracts/test/erc20/FreeMintERC20.sol 0.00% <0.00%> (ø)
...ocol/contracts/test/erc20/MayFailFreeMintERC20.sol 0.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@dantaik dantaik added this pull request to the merge queue Feb 28, 2023
Merged via the queue into main with commit 0d3e769 Feb 28, 2023
@dantaik dantaik deleted the erc20_deploy branch February 28, 2023 01:17
@github-actions github-actions bot mentioned this pull request Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants