Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(protocol): extract two anchor-related functions #13199

Merged
merged 9 commits into from
Feb 22, 2023
Merged

Conversation

dantaik
Copy link
Contributor

@dantaik dantaik commented Feb 22, 2023

  • Refactor the TaikoL1 contract to have two functions for validating anchor transactions. This is not only for better readability, but to make it easier to delete those functions later when anchors can be verified in ZKPs.
  • Removed all "@author" from comments
  • Fixed a few solint errors
  • Renamed enableProofValidation to enableAnchorValidation

davidtaikocha
davidtaikocha previously approved these changes Feb 22, 2023
@codecov
Copy link

codecov bot commented Feb 22, 2023

Codecov Report

Merging #13199 (fc0a860) into main (16993cd) will increase coverage by 1.04%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main   #13199      +/-   ##
==========================================
+ Coverage   60.19%   61.24%   +1.04%     
==========================================
  Files         115      115              
  Lines        3442     3385      -57     
  Branches      466      432      -34     
==========================================
+ Hits         2072     2073       +1     
+ Misses       1283     1225      -58     
  Partials       87       87              
Flag Coverage Δ *Carryforward flag
bridge-ui 92.61% <ø> (ø) Carriedforward from 05a3c86
protocol 52.70% <ø> (+1.58%) ⬆️ Carriedforward from 05a3c86
relayer 65.30% <ø> (+0.15%) ⬆️
ui 100.00% <ø> (ø) Carriedforward from 05a3c86

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
packages/protocol/contracts/L1/ProofVerifier.sol 0.00% <ø> (ø)
packages/protocol/contracts/L1/TaikoL1.sol 31.48% <ø> (ø)
packages/protocol/contracts/L1/TkoToken.sol 84.21% <ø> (ø)
...ckages/protocol/contracts/L1/libs/LibProposing.sol 6.57% <ø> (ø)
packages/protocol/contracts/L1/libs/LibProving.sol 0.00% <ø> (ø)
packages/protocol/contracts/L1/libs/LibUtils.sol 32.75% <ø> (ø)
...ckages/protocol/contracts/L1/libs/LibVerifying.sol 9.61% <ø> (ø)
packages/protocol/contracts/L2/TaikoL2.sol 53.84% <ø> (ø)
packages/protocol/contracts/bridge/Bridge.sol 41.17% <ø> (ø)
...ackages/protocol/contracts/bridge/BridgedERC20.sol 95.65% <ø> (ø)
... and 44 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@dantaik dantaik self-assigned this Feb 22, 2023
@dantaik dantaik enabled auto-merge February 22, 2023 04:23
@dantaik dantaik changed the title refactor(protocol): extract two anchor related functions refactor(protocol): extract two anchor-related functions Feb 22, 2023
@dantaik dantaik requested a review from dionysuzx February 22, 2023 12:29
@dantaik dantaik added this pull request to the merge queue Feb 22, 2023
Merged via the queue into main with commit 9c3fb10 Feb 22, 2023
@dantaik dantaik deleted the anchor_refactor branch February 22, 2023 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants