-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(protocol): extract two anchor-related functions #13199
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
dantaik
commented
Feb 22, 2023
•
edited
Loading
edited
- Refactor the TaikoL1 contract to have two functions for validating anchor transactions. This is not only for better readability, but to make it easier to delete those functions later when anchors can be verified in ZKPs.
- Removed all "@author" from comments
- Fixed a few solint errors
- Renamed enableProofValidation to enableAnchorValidation
dantaik
requested review from
davidtaikocha,
cyberhorsey and
RogerLamTd
and removed request for
cyberhorsey
February 22, 2023 03:59
davidtaikocha
previously approved these changes
Feb 22, 2023
Codecov Report
@@ Coverage Diff @@
## main #13199 +/- ##
==========================================
+ Coverage 60.19% 61.24% +1.04%
==========================================
Files 115 115
Lines 3442 3385 -57
Branches 466 432 -34
==========================================
+ Hits 2072 2073 +1
+ Misses 1283 1225 -58
Partials 87 87
*This pull request uses carry forward flags. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
dantaik
changed the title
refactor(protocol): extract two anchor related functions
refactor(protocol): extract two anchor-related functions
Feb 22, 2023
davidtaikocha
approved these changes
Feb 22, 2023
cyberhorsey
approved these changes
Feb 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.