feat(protocol): support backward-compatible batch-proof verification #17968
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: dantaik <dantaik@users.noreply.github.com>
This reverts commit 8113502.
Co-authored-by: D <51912515+adaki2004@users.noreply.github.com>
Brechtpd
approved these changes
Aug 28, 2024
dantaik
changed the title
davidtaikocha
approved these changes
Aug 29, 2024
dantaik
requested review from
adaki2004
and removed request for
smtmfft,
cyberhorsey and
adaki2004
davidtaikocha
approved these changes
Aug 29, 2024
This was referenced Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces support for batch proofs (also known as aggregated proofs) in our BCR protocol. The changes include new interfaces and functions to accommodate both individual and batch proof verification.
Added
verifyBatchProoffunction toIVerifierinterface.Most verifiers haven't implemented this function yet, but the protocol remains functional.
Introduced
proveBlocksV2function inITaikoL2.It supports two modes:
Mode selection for
proveBlocksV2verifyBatchProof, separate-proving mode should be used.verifyBatchProofrequire batch-proving mode exclusively.Original PR: #17938