Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(protocol): Based Contestable Rollup with multi-proofs and multi-hop bridging #14705

Merged
merged 111 commits into from
Nov 15, 2023
Merged

feat(protocol): Based Contestable Rollup with multi-proofs and multi-hop bridging #14705

merged 111 commits into from
Nov 15, 2023

Conversation

dantaik
Copy link
Contributor

@dantaik dantaik commented Sep 18, 2023 •
edited
Loading

The following major changes are included in this PR:

  • refactored token vault contracts, now they have a common base to handle interaction with the Bridge contract.
  • Bridge contract and token vaults no longer check the to address, it will handled on the destination bridge/vault without failure.
  • Bridge allows message.to to be a TaikoL1 contract address.
  • Merged EtherVault into Bridge to simplify deployment
  • Added a AuthorizableContract contract.
  • SignalService is now an AuthorizableContract contract.
  • New contract owner must claim the ownership.
  • Allow owner to pause proving/verifying blocks.
  • Ensure proposer is EOA when use calldata for DA (otherwise it's hard for client to download the calldata)
  • Ensure chain ID is a uint64 so it can be made part of the address of each pre-deployment contract.
  • SignalService's proof need to have an crossChainSync address.
  • Enabled multi-hop bridging (read [more](Read this: https://github.com/taikoxyz/taiko-mono/blob/bridgable_app/packages/protocol/docs/multihop_bridging_deployment.md
    )).
  • Added SGX prover
  • AddressManager can set an name to address(0), but in reality, the in-production AddressManager's getAddress function should be a pure function.
  • TaikoToken no longer has the burn or mint function
  • No special handling for Taiko token in ERC20Vault.
  • Removed unnecessary OZ imports from TaikoToken.sol
  • Allow admin to pause Bridge and Vaults.
  • Disable pausing TaikoToken transfers.
  • Support EIP-4844 as DA.

@dantaik @dong77
feat(protocol): Contestable zkRollup [DRAFT] (#14703)
74783f3 
Co-authored-by: Daniel Wang <dong77@gmail.com>
@vercel
Copy link

vercel bot commented Sep 18, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
bridge-ui-v2-a5 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 15, 2023 10:36am
bridge-ui-v2-internal ✅ Ready (Inspect) Visit Preview Nov 15, 2023 10:36am
taiko-mono-bridge-ui-grimsvotn ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 15, 2023 10:36am
website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 15, 2023 10:36am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
geth-diff ⬜️ Ignored (Inspect) Visit Preview Nov 15, 2023 10:36am

@dantaik dantaik marked this pull request as ready for review September 18, 2023 13:28
@dantaik dantaik marked this pull request as draft September 18, 2023 13:28
@Brechtpd

This comment was marked as resolved.

Sign in to view
@dantaik @dong77
fix(protocol): get around forge bug (#15192)
1c273b0 
Co-authored-by: Daniel Wang <dong77@gmail.com>
@dantaik @dong77
@adaki2004 @davidtaikocha @cyberhorsey @Brechtpd
refactor(protocol): refactor bridge/vault/signal for multi-chain depl…
3069a52 
…oyment (#15061)

Co-authored-by: Daniel Wang <dong77@gmail.com>
Co-authored-by: adaki2004 <keszeydani@gmail.com>
Co-authored-by: D <51912515+adaki2004@users.noreply.github.com>
Co-authored-by: David <david@taiko.xyz>
Co-authored-by: jeff <113397187+cyberhorsey@users.noreply.github.com>
Co-authored-by: Jeffery Walsh <cyberhorsey@gmail.com>
Co-authored-by: Brecht Devos <Brechtp.Devos@gmail.com>
@dantaik dantaik changed the title feat(protocol): Contestable multi-prover rollup & bridging fixes feat(protocol): Based Contestable Rollup with multi-proofs and multi-hop bridging Nov 15, 2023
@dantaik dantaik changed the base branch from main to based_contestable_zkrollup November 15, 2023 10:31
@dantaik dantaik merged commit 28000b3 into based_contestable_zkrollup Nov 15, 2023
16 checks passed
@dantaik dantaik deleted the contestable-zkrollup branch November 15, 2023 10:52
This was referenced Feb 9, 2024
Closed
Closed
Closed
Closed
Merged
@github-actions github-actions bot mentioned this pull request Feb 20, 2024
Closed
@taiko-kitty taiko-kitty mentioned this pull request Mar 1, 2024
Closed
@taiko-kitty taiko-kitty mentioned this pull request Mar 29, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidtaikocha davidtaikocha davidtaikocha left review comments

@Brechtpd Brechtpd Awaiting requested review from Brechtpd

@adaki2004 adaki2004 Awaiting requested review from adaki2004

@smtmfft smtmfft Awaiting requested review from smtmfft

Assignees

@adaki2004 adaki2004

Labels
area.protocol category.feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@dantaik @Brechtpd @adaki2004 @smtmfft @davidtaikocha @dong77 @cyberhorsey @mvidovic-tuple