feat(protocol): use blobhash() and remove BlobHashReader.yulp (#1…

…5610)
taikoxyz · Jan 30, 2024 · d886ad7 · d886ad7
1 parent 8580a57
commit d886ad7
Show file tree

Hide file tree

Showing 6 changed files with 7 additions and 67 deletions.
diff --git a/packages/protocol/contracts/4844/BlobHashReader.yulp b/packages/protocol/contracts/4844/BlobHashReader.yulp
diff --git a/packages/protocol/contracts/4844/IBlobHashReader.sol b/packages/protocol/contracts/4844/IBlobHashReader.sol
diff --git a/packages/protocol/contracts/L1/libs/LibProposing.sol b/packages/protocol/contracts/L1/libs/LibProposing.sol
@@ -15,7 +15,6 @@
 pragma solidity 0.8.24;
 
 import "lib/openzeppelin-contracts/contracts/token/ERC20/IERC20.sol";
-import "../../4844/IBlobHashReader.sol";
 import "../../common/AddressResolver.sol";
 import "../../libs/LibAddress.sol";
 import "../hooks/IHook.sol";
@@ -143,8 +142,7 @@ library LibProposing {
                 // proposeBlock functions are called more than once in the same
                 // L1 transaction, these multiple L2 blocks will share the same
                 // blob.
-                meta.blobHash =
-                    IBlobHashReader(resolver.resolve("blob_hash_reader", false)).getFirstBlobHash();
+                meta.blobHash = blobhash(0);
 
                 if (meta.blobHash == 0) revert L1_BLOB_NOT_FOUND();
 

diff --git a/packages/protocol/genesis/generate_genesis.test.sh b/packages/protocol/genesis/generate_genesis.test.sh
@@ -101,5 +101,6 @@ forge test \
   --fork-url http://localhost:18545 \
   --fork-retry-backoff 120 \
   --no-storage-caching \
+  --evm-version cancun \
   --match-path genesis/*.g.sol \
   --block-gas-limit 1000000000
diff --git a/packages/protocol/package.json b/packages/protocol/package.json
@@ -5,18 +5,18 @@
   "scripts": {
     "buildMerkle": "ts-node ./utils/airdrop/buildMerkleTree.ts ./utils/airdrop/airdrop_db/example_claimList.json",
     "clean": "rm -rf abis cache* && forge clean",
-    "compile": "forge build --build-info --extra-output storage-layout",
+    "compile": "forge build --evm-version cancun --build-info --extra-output storage-layout",
     "deploy:foundry": "./script/download_solc.sh && ./script/test_deploy_on_l1.sh",
     "eslint": "pnpm exec eslint --ignore-path .eslintignore --ext .js,.ts .",
     "eslint:fix": "pnpm exec eslint --ignore-path .eslintignore --ext .js,.ts . --fix",
     "fmt:sol": "forge fmt",
     "generate:genesis": "ts-node ./utils/generate_genesis/main.ts",
     "lint:sol": "forge fmt && pnpm solhint 'contracts/**/*.sol' --fix",
-    "snapshot": "forge snapshot --match-path 'test/**/*.t.sol'",
-    "test": "forge test -vvv --match-path test/*.t.sol",
+    "snapshot": "forge snapshot --evm-version cancun --match-path 'test/**/*.t.sol'",
+    "test": "forge test -vvv --evm-version cancun --match-path test/*.t.sol",
     "test:coverage": "mkdir -p coverage && forge coverage --report lcov && lcov --remove ./lcov.info -o ./coverage/lcov.info 'test/' 'script/' 'contracts/thirdparty/' && genhtml coverage/lcov.info --branch-coverage --output-dir coverage --ignore-errors category && open coverage/index.html",
     "test:genesis": "pnpm compile && FOUNDRY_PROFILE=genesis ./genesis/generate_genesis.test.sh",
-    "export:simconf": "forge test --match-test 'test_simulation' -vv > simulation/out/simconf_$(date +%s).txt"
+    "export:simconf": "forge test --evm-version cancun --match-test 'test_simulation' -vv > simulation/out/simconf_$(date +%s).txt"
   },
   "keywords": [
     "ZKP",

diff --git a/packages/protocol/script/test_deploy_on_l1.sh b/packages/protocol/script/test_deploy_on_l1.sh
@@ -20,6 +20,7 @@ forge script script/DeployOnL1.s.sol:DeployOnL1 \
     --fork-url http://localhost:8545 \
     --broadcast \
     --ffi \
+    --evm-version cancun \
     -vvvv \
     --private-key 0xac0974bec39a17e36ba4a6b4d238ff944bacb478cbed5efcae784d7bf4f2ff80 \
     --block-gas-limit 100000000