Better approach

taikoxyz · Mar 21, 2023 · 06444c0 · 06444c0
1 parent 3358e29
commit 06444c0
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/packages/bridge-ui/src/App.svelte b/packages/bridge-ui/src/App.svelte
@@ -242,6 +242,7 @@
     pausable: false,
   };
 
+  // TODO: Not found route
   const routes = {
     '/:tab?': wrap({
       component: Home,

diff --git a/packages/bridge-ui/src/pages/home/Home.svelte b/packages/bridge-ui/src/pages/home/Home.svelte
@@ -10,9 +10,12 @@
   let bridgeWidth: number;
   let bridgeHeight: number;
 
-  $: activeTab = $location.replace('/', '').startsWith('transactions')
-    ? 'transactions'
-    : 'bridge';
+  // TODO: think about a more general approach here.
+  //       We're assuming we have two tabs. The base location
+  //       corresponde with `bridge` tab => /, otherwise we're
+  //       opening the second tab `transactions`. What if we add
+  //       a new tab?
+  $: activeTab = $location === '/' ? 'bridge' : 'transactions';
 
   // TODO: do we really need all these tricks to style containers
   //       Rethink this part: fluid, fixing on small screens