Skip to content
This repository has been archived by the owner on May 11, 2024. It is now read-only.

feat(prover): fix / upgrade integration test #496

Merged
merged 9 commits into from
Jan 12, 2024

Conversation

mask-pp
Copy link
Contributor

@mask-pp mask-pp commented Jan 11, 2024

Split integration-test into 3 steps:

  1. Shell scripts to control docker compose.
  2. Scripts for deploy l1 contracts.
  3. Integration-test scripts.
  4. Replace common.Hex2Bytes with common.FromHex, so that we don't need to consider the "0x" prefix.

@mask-pp mask-pp changed the title Fix/upgrate integration test feat(test): Fix/upgrate integration test Jan 11, 2024
@mask-pp mask-pp changed the title feat(test): Fix/upgrate integration test feat(prover): Fix/upgrate integration test Jan 11, 2024
@mask-pp mask-pp requested review from davidtaikocha and cyberhorsey and removed request for davidtaikocha January 11, 2024 08:28
@davidtaikocha
Copy link
Member

davidtaikocha commented Jan 11, 2024

image

Looks like the github action is failed (but don't know why it says successful in this PR page...)

ref: https://github.com/taikoxyz/taiko-client/actions/runs/7486090636/job/20375748869

@mask-pp
Copy link
Contributor Author

mask-pp commented Jan 11, 2024

image Looks like the github action is failed (but don't know why it says successful in this PR page...)

ref: https://github.com/taikoxyz/taiko-client/actions/runs/7486090636/job/20375748869

Because check_command solc is unnecessary check failed means that integration_test has done nothing, and has fixed in this commit.

Copy link

codecov bot commented Jan 11, 2024

Codecov Report

Attention: 12 lines in your changes are missing coverage. Please review.

Comparison is base (2156b49) 58.19% compared to head (a641286) 58.15%.
Report is 3 commits behind head on main.

Files Patch % Lines
prover/config.go 18.18% 7 Missing and 2 partials ⚠️
prover/prover.go 25.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #496      +/-   ##
==========================================
- Coverage   58.19%   58.15%   -0.05%     
==========================================
  Files          44       44              
  Lines        5523     5532       +9     
==========================================
+ Hits         3214     3217       +3     
- Misses       1991     1994       +3     
- Partials      318      321       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@davidtaikocha davidtaikocha changed the title feat(prover): Fix/upgrate integration test feat(prover): fix / upgrade integration test Jan 11, 2024
docker/start.sh Show resolved Hide resolved
docker/start.sh Outdated Show resolved Hide resolved
integration_test/deploy_l1_contract.sh Outdated Show resolved Hide resolved
integration_test/l1_env.sh Outdated Show resolved Hide resolved
scripts/common.sh Outdated Show resolved Hide resolved
mask-pp and others added 5 commits January 11, 2024 23:00
Co-authored-by: David <david@taiko.xyz>
Co-authored-by: David <david@taiko.xyz>
Co-authored-by: David <david@taiko.xyz>
Co-authored-by: David <david@taiko.xyz>
@davidtaikocha davidtaikocha enabled auto-merge (squash) January 12, 2024 02:02
@davidtaikocha davidtaikocha merged commit c63e681 into main Jan 12, 2024
4 checks passed
@davidtaikocha davidtaikocha deleted the fix/upgrate_integration_test branch January 12, 2024 02:07
davidtaikocha added a commit that referenced this pull request Jan 12, 2024
Co-authored-by: David <david@taiko.xyz>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants