Skip to content
This repository has been archived by the owner on May 11, 2024. It is now read-only.

fix(prover): Reorder guardian prover sign + add allowance flag/logic #457

Merged
merged 17 commits into from
Dec 1, 2023

Conversation

cyberhorsey
Copy link
Contributor

@cyberhorsey cyberhorsey commented Nov 30, 2023

make sure L1 origin is synced for block ID before trying to sign the block hash, and add logs.

this also adds an allowance flag for the prover, which should both mitigate a LOT of devrel related help (as every day many people ask for "how do i set allowance" and "how much should i set", so we can set a sane default in the docker scripts), and let us have easier internal deployments so we dont have to approve every internal l1prover manually.

Copy link

codecov bot commented Nov 30, 2023

Codecov Report

Attention: 33 lines in your changes are missing coverage. Please review.

Comparison is base (df91c51) 60.62% compared to head (b99054c) 60.65%.

❗ Current head b99054c differs from pull request most recent head 0193e35. Consider uploading reports for the commit 0193e35 to get more accurate results

Files Patch % Lines
prover/prover.go 60.52% 22 Missing and 8 partials ⚠️
prover/config.go 62.50% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #457      +/-   ##
==========================================
+ Coverage   60.62%   60.65%   +0.02%     
==========================================
  Files          45       45              
  Lines        5341     5421      +80     
==========================================
+ Hits         3238     3288      +50     
- Misses       1780     1802      +22     
- Partials      323      331       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cyberhorsey cyberhorsey changed the title fix(prover): Reorder guardian prover sign fix(prover): Reorder guardian prover sign + add allowance flag/logic Dec 1, 2023
prover/prover.go Outdated Show resolved Hide resolved
prover/prover.go Outdated Show resolved Hide resolved
@davidtaikocha davidtaikocha enabled auto-merge (squash) December 1, 2023 03:22
@davidtaikocha davidtaikocha merged commit 4bc2a63 into main Dec 1, 2023
4 checks passed
@davidtaikocha davidtaikocha deleted the reorder_guardian_prover_sign branch December 1, 2023 03:28
davidtaikocha added a commit that referenced this pull request Dec 1, 2023
davidtaikocha added a commit that referenced this pull request Dec 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants