Skip to content
This repository has been archived by the owner on May 11, 2024. It is now read-only.

feat(prover): update ZkevmRpcdProducer to integrate new circuits #217

Merged
merged 7 commits into from
May 11, 2023
Merged

feat(prover): update ZkevmRpcdProducer to integrate new circuits #217

merged 7 commits into from
May 11, 2023

Conversation

davidtaikocha
Copy link
Member

@davidtaikocha davidtaikocha commented May 11, 2023 •
edited
Loading

@davidtaikocha davidtaikocha self-assigned this May 11, 2023
@davidtaikocha davidtaikocha marked this pull request as draft May 11, 2023 15:40
@davidtaikocha davidtaikocha marked this pull request as ready for review May 11, 2023 16:22
@codecov
Copy link

codecov bot commented May 11, 2023 •
edited
Loading

Codecov Report

Merging #217 (775200c) into main (79ba210) will decrease coverage by 0.05%.
The diff coverage is 40.54%.

❗ Current head 775200c differs from pull request most recent head 53e5564. Consider uploading reports for the commit 53e5564 to get more accurate results

@@            Coverage Diff             @@
##             main     #217      +/-   ##
==========================================
- Coverage   52.75%   52.71%   -0.05%     
==========================================
  Files          36       36              
  Lines        3357     3413      +56     
==========================================
+ Hits         1771     1799      +28     
- Misses       1356     1378      +22     
- Partials      230      236       +6
Impacted Files Coverage Δ
driver/config.go 75.00% <ø> (-1.00%) ⬇️
prover/proof_producer/proof_producer.go 0.00% <ø> (ø)
prover/proof_producer/zkevm_rpcd_producer.go 27.04% <0.00%> (-2.69%) ⬇️
prover/proof_submitter/valid_proof_submitter.go 61.50% <55.81%> (-1.86%) ⬇️
driver/driver.go 60.58% <62.50%> (-0.19%) ⬇️
proposer/proposer.go 63.36% <100.00%> (ø)

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@davidtaikocha davidtaikocha changed the title feat(prover): update ZkevmRpcdProducer to integrate new circuits feat(prover): update ZkevmRpcdProducer to integrate new circuits May 11, 2023
@cyberhorsey cyberhorsey merged commit 81cf612 into main May 11, 2023
@cyberhorsey cyberhorsey deleted the integrate-new-zkevm-chian branch May 11, 2023 19:19
@github-actions github-actions bot mentioned this pull request May 11, 2023
Merged
vhjiang pushed a commit to taikoverse/taiko-degen-client that referenced this pull request Jul 1, 2023
@davidtaikocha
feat(prover): update ZkevmRpcdProducer to integrate new circuits (t…
9aa7982 
…aikoxyz#217)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cyberhorsey cyberhorsey cyberhorsey approved these changes

@RogerLamTd RogerLamTd Awaiting requested review from RogerLamTd

Assignees

@davidtaikocha davidtaikocha

Labels
area.client.prover area.client meta.alpha-3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davidtaikocha @cyberhorsey