-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
258 behavior velocity occlusion spot stability #12
Conversation
Signed-off-by: tanaka3 <ttatcoder@outlook.jp>
…n area length Signed-off-by: taikitanaka3 <taiki.tanaka@tier4.jp>
Signed-off-by: taikitanaka3 <taiki.tanaka@tier4.jp>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy
found issue(s) with the introduced code (1/1)
@@ -97,6 +98,7 @@ struct PlannerData | |||
// additional parameters | |||
double max_stop_acceleration_threshold; | |||
double max_stop_jerk_threshold; | |||
double system_delay; | |||
double delay_response_time; | |||
double stop_line_extend_length; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
constructor does not initialize these fields: stop_line_extend_length, accel_lowpass_gain_
double stop_line_extend_length; | |
double stop_line_extend_length{}; |
} | ||
|
||
template <> | ||
inline void doTransform( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
function template specialization tf2::doTransform<geometry_msgs::msg::Point_<std::allocator<void> > >
has a primary template declaration with different parameter names
grid_map::GridMap & grid_map, const GridParam & param, const bool is_show_debug_window, | ||
const bool filter_occupancy_grid) | ||
const bool filter_occupancy_grid, const bool use_object_footprints, | ||
const bool use_object_ray_casts) | ||
{ | ||
OccupancyGrid occupancy_grid = *occupancy_grid_ptr; | ||
cv::Mat cv_image( | ||
occupancy_grid.info.width, occupancy_grid.info.height, CV_8UC1, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use of a signed integer operand with a binary bitwise operator
} | ||
} | ||
debug_point = points; | ||
return parked_vehicles; | ||
return; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
redundant return statement at the end of a function with a void return type
return; | |
@@ -62,6 +62,7 @@ class OcclusionSpotModule : public SceneModuleInterface | |||
PlannerParam param_; | |||
tier4_autoware_utils::StopWatch<std::chrono::milliseconds> stop_watch_; | |||
std::vector<lanelet::BasicPolygon2d> partition_lanelets_; | |||
double prev_detection_area_length_; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
constructor does not initialize these fields: prev_detection_area_length_
double prev_detection_area_length_; | |
double prev_detection_area_length_{}; |
Note: Confirm the contribution guidelines before submitting a pull request.
Click the
Preview
tab and select a PR template:Do NOT send a PR with this description.