Align default strip behavior to Cargo 1.77+'s default #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taiki-e
force-pushed
the
strip
branch
4 times, most recently
from
740041c to
0738aea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As said in #59, strip=debuginfo became the default behavior of Cargo 1.77+'s release build. (rust-lang/cargo#13257)
On 1.77+, use Cargo's default (i.e., we don't set anything), and on pre-1.77, align to Cargo 1.77+'s default (set
CARGO_PROFILE_RELEASE_STRIP=debuginfo).This action was created before the strip in cargo profile was stabilized, so it required a strip on our part, we can finally remove this!
Closes #59