Update ui tests to nightly-2021-04-13 #324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taiki-e
commented
Apr 13, 2021
Comment on lines
25
to
52
| thread 'rustc' panicked at 'no errors encountered even though `delay_span_bug` issued', compiler/rustc_errors/src/lib.rs:1018:13 | ||
| stack backtrace: | ||
| 0: _rust_begin_unwind | ||
| 1: std::panicking::begin_panic_fmt | ||
| 2: rustc_errors::HandlerInner::flush_delayed | ||
| 3: <rustc_errors::HandlerInner as core::ops::drop::Drop>::drop | ||
| 4: core::ptr::drop_in_place<rustc_session::parse::ParseSess> | ||
| 5: <alloc::rc::Rc<T> as core::ops::drop::Drop>::drop | ||
| 6: core::ptr::drop_in_place<rustc_interface::interface::Compiler> | ||
| 7: rustc_span::with_source_map | ||
| 8: rustc_interface::interface::create_compiler_and_run | ||
| 9: scoped_tls::ScopedKey<T>::set | ||
| note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace. | ||
|
|
||
| error: internal compiler error: unexpected panic | ||
|
|
||
| note: the compiler unexpectedly panicked. this is a bug. | ||
|
|
||
| note: we would appreciate a bug report: https://github.com/rust-lang/rust/issues/new?labels=C-bug%2C+I-ICE%2C+T-compiler&template=ice.md | ||
|
|
||
| note: rustc 1.53.0-nightly (d0695c908 2021-04-12) running on x86_64-apple-darwin | ||
|
|
||
| note: compiler flags: -C embed-bitcode=no -C split-debuginfo=unpacked -C debuginfo=2 --crate-type bin | ||
|
|
||
| note: some of the compiler flags provided by cargo are hidden | ||
|
|
||
| query stack during panic: | ||
| end of query stack |
There was a problem hiding this comment.
It's a bad idea to include an error message in the cross-platform ui test that includes the name of the toolchain and the target, so we need to avoid this.
There was a problem hiding this comment.
Looks like rust-lang/rust#83921
There was a problem hiding this comment.
So I don't think we should rely on the behavior of rustc that handles this correctly. That is, all repr(packed ...) should be rejected on our part.
taiki-e
force-pushed
the
ui
branch
2 times, most recently
from
8dd9b64 to
c34d374
Compare
They will be rejected by rustc, but we should not rely on the behavior of rustc that rejects them.
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.