Suppress clippy::missing_const_for_fn lint in generated code

taiki-e · Feb 3, 2025 · 1003f80 · 1003f80
1 parent c6d2ebc
commit 1003f80
Show file tree

Hide file tree

Showing 39 changed files with 55 additions and 36 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -12,6 +12,8 @@ Note: In this file, do not use the hard wrap in the middle of a sentence for com
 
 ## [Unreleased]
 
+- Suppress `clippy::missing_const_for_fn` lint in generated code.
+
 ## [1.1.8] - 2025-01-06
 
 - Suppress `unnameable_types`, `clippy::absolute_paths`, `clippy::min_ident_chars`, `clippy::pub_with_shorthand`, `clippy::single_call_fn`, `clippy::single_char_lifetime_names` lints in generated code.

diff --git a/pin-project-internal/src/pin_project/derive.rs b/pin-project-internal/src/pin_project/derive.rs
@@ -89,6 +89,7 @@ impl GenerateTokens {
             #[allow(
                 unused_qualifications,
                 #allowed_lints
+                clippy::missing_const_for_fn,
                 clippy::needless_lifetimes,
                 clippy::semicolon_if_nothing_returned,
                 clippy::use_self,
@@ -972,7 +973,6 @@ fn make_proj_impl(
     });
     let mut project_ref = Some(quote! {
         #allow_dead_code
-        #[allow(clippy::missing_const_for_fn)]
         #[inline]
         #vis fn project_ref<#lifetime>(
             self: _pin_project::__private::Pin<&#lifetime Self>,

diff --git a/pin-project-internal/src/pinned_drop.rs b/pin-project-internal/src/pinned_drop.rs
@@ -231,6 +231,7 @@ fn expand_impl(item: &mut ItemImpl) {
 
     method.block.stmts = parse_quote! {
         #[allow(
+            clippy::missing_const_for_fn,
             clippy::needless_pass_by_value, // This lint does not warn the receiver.
             clippy::single_call_fn
         )]

diff --git a/tests/expand/default/enum.expanded.rs b/tests/expand/default/enum.expanded.rs
@@ -75,6 +75,7 @@ where
     clippy::redundant_pub_crate,
     clippy::single_char_lifetime_names,
     clippy::type_repetition_in_bounds,
+    clippy::missing_const_for_fn,
     clippy::needless_lifetimes,
     clippy::semicolon_if_nothing_returned,
     clippy::use_self,
@@ -108,7 +109,6 @@ const _: () = {
             }
         }
         #[allow(dead_code)]
-        #[allow(clippy::missing_const_for_fn)]
         #[inline]
         fn project_ref<'pin>(
             self: _pin_project::__private::Pin<&'pin Self>,

diff --git a/tests/expand/default/struct.expanded.rs b/tests/expand/default/struct.expanded.rs
@@ -20,6 +20,7 @@ struct Struct<T, U> {
     clippy::redundant_pub_crate,
     clippy::single_char_lifetime_names,
     clippy::type_repetition_in_bounds,
+    clippy::missing_const_for_fn,
     clippy::needless_lifetimes,
     clippy::semicolon_if_nothing_returned,
     clippy::use_self,
@@ -59,7 +60,6 @@ const _: () = {
             }
         }
         #[allow(dead_code)]
-        #[allow(clippy::missing_const_for_fn)]
         #[inline]
         fn project_ref<'pin>(
             self: _pin_project::__private::Pin<&'pin Self>,

diff --git a/tests/expand/default/tuple_struct.expanded.rs b/tests/expand/default/tuple_struct.expanded.rs
@@ -16,6 +16,7 @@ struct TupleStruct<T, U>(#[pin] T, U);
     clippy::redundant_pub_crate,
     clippy::single_char_lifetime_names,
     clippy::type_repetition_in_bounds,
+    clippy::missing_const_for_fn,
     clippy::needless_lifetimes,
     clippy::semicolon_if_nothing_returned,
     clippy::use_self,
@@ -53,7 +54,6 @@ const _: () = {
             }
         }
         #[allow(dead_code)]
-        #[allow(clippy::missing_const_for_fn)]
         #[inline]
         fn project_ref<'pin>(
             self: _pin_project::__private::Pin<&'pin Self>,

diff --git a/tests/expand/multifields/enum.expanded.rs b/tests/expand/multifields/enum.expanded.rs
@@ -132,6 +132,7 @@ enum EnumProjOwn<T, U> {
     clippy::redundant_pub_crate,
     clippy::single_char_lifetime_names,
     clippy::type_repetition_in_bounds,
+    clippy::missing_const_for_fn,
     clippy::needless_lifetimes,
     clippy::semicolon_if_nothing_returned,
     clippy::use_self,
@@ -173,7 +174,6 @@ const _: () = {
             }
         }
         #[allow(dead_code)]
-        #[allow(clippy::missing_const_for_fn)]
         #[inline]
         fn project_ref<'pin>(
             self: _pin_project::__private::Pin<&'pin Self>,

diff --git a/tests/expand/multifields/struct.expanded.rs b/tests/expand/multifields/struct.expanded.rs
@@ -23,6 +23,7 @@ struct Struct<T, U> {
     clippy::redundant_pub_crate,
     clippy::single_char_lifetime_names,
     clippy::type_repetition_in_bounds,
+    clippy::missing_const_for_fn,
     clippy::needless_lifetimes,
     clippy::semicolon_if_nothing_returned,
     clippy::use_self,
@@ -76,7 +77,6 @@ const _: () = {
             }
         }
         #[allow(dead_code)]
-        #[allow(clippy::missing_const_for_fn)]
         #[inline]
         fn project_ref<'pin>(
             self: _pin_project::__private::Pin<&'pin Self>,

diff --git a/tests/expand/multifields/tuple_struct.expanded.rs b/tests/expand/multifields/tuple_struct.expanded.rs
@@ -16,6 +16,7 @@ struct TupleStruct<T, U>(#[pin] T, #[pin] T, U, U);
     clippy::redundant_pub_crate,
     clippy::single_char_lifetime_names,
     clippy::type_repetition_in_bounds,
+    clippy::missing_const_for_fn,
     clippy::needless_lifetimes,
     clippy::semicolon_if_nothing_returned,
     clippy::use_self,
@@ -66,7 +67,6 @@ const _: () = {
             }
         }
         #[allow(dead_code)]
-        #[allow(clippy::missing_const_for_fn)]
         #[inline]
         fn project_ref<'pin>(
             self: _pin_project::__private::Pin<&'pin Self>,

diff --git a/tests/expand/naming/enum-all.expanded.rs b/tests/expand/naming/enum-all.expanded.rs
@@ -99,6 +99,7 @@ enum ProjOwn<T, U> {
     clippy::redundant_pub_crate,
     clippy::single_char_lifetime_names,
     clippy::type_repetition_in_bounds,
+    clippy::missing_const_for_fn,
     clippy::needless_lifetimes,
     clippy::semicolon_if_nothing_returned,
     clippy::use_self,
@@ -129,7 +130,6 @@ const _: () = {
             }
         }
         #[allow(dead_code)]
-        #[allow(clippy::missing_const_for_fn)]
         #[inline]
         fn project_ref<'pin>(
             self: _pin_project::__private::Pin<&'pin Self>,

diff --git a/tests/expand/naming/enum-mut.expanded.rs b/tests/expand/naming/enum-mut.expanded.rs
@@ -49,6 +49,7 @@ where
     clippy::redundant_pub_crate,
     clippy::single_char_lifetime_names,
     clippy::type_repetition_in_bounds,
+    clippy::missing_const_for_fn,
     clippy::needless_lifetimes,
     clippy::semicolon_if_nothing_returned,
     clippy::use_self,

diff --git a/tests/expand/naming/enum-none.expanded.rs b/tests/expand/naming/enum-none.expanded.rs
@@ -20,6 +20,7 @@ enum Enum<T, U> {
     clippy::redundant_pub_crate,
     clippy::single_char_lifetime_names,
     clippy::type_repetition_in_bounds,
+    clippy::missing_const_for_fn,
     clippy::needless_lifetimes,
     clippy::semicolon_if_nothing_returned,
     clippy::use_self,

diff --git a/tests/expand/naming/enum-own.expanded.rs b/tests/expand/naming/enum-own.expanded.rs
@@ -44,6 +44,7 @@ enum ProjOwn<T, U> {
     clippy::redundant_pub_crate,
     clippy::single_char_lifetime_names,
     clippy::type_repetition_in_bounds,
+    clippy::missing_const_for_fn,
     clippy::needless_lifetimes,
     clippy::semicolon_if_nothing_returned,
     clippy::use_self,

diff --git a/tests/expand/naming/enum-ref.expanded.rs b/tests/expand/naming/enum-ref.expanded.rs
@@ -46,6 +46,7 @@ where
     clippy::redundant_pub_crate,
     clippy::single_char_lifetime_names,
     clippy::type_repetition_in_bounds,
+    clippy::missing_const_for_fn,
     clippy::needless_lifetimes,
     clippy::semicolon_if_nothing_returned,
     clippy::use_self,
@@ -56,7 +57,6 @@ const _: () = {
     extern crate pin_project as _pin_project;
     impl<T, U> Enum<T, U> {
         #[allow(dead_code)]
-        #[allow(clippy::missing_const_for_fn)]
         #[inline]
         fn project_ref<'pin>(
             self: _pin_project::__private::Pin<&'pin Self>,

diff --git a/tests/expand/naming/struct-all.expanded.rs b/tests/expand/naming/struct-all.expanded.rs
@@ -91,6 +91,7 @@ struct ProjOwn<T, U> {
     clippy::redundant_pub_crate,
     clippy::single_char_lifetime_names,
     clippy::type_repetition_in_bounds,
+    clippy::missing_const_for_fn,
     clippy::needless_lifetimes,
     clippy::semicolon_if_nothing_returned,
     clippy::use_self,
@@ -114,7 +115,6 @@ const _: () = {
             }
         }
         #[allow(dead_code)]
-        #[allow(clippy::missing_const_for_fn)]
         #[inline]
         fn project_ref<'pin>(
             self: _pin_project::__private::Pin<&'pin Self>,

diff --git a/tests/expand/naming/struct-mut.expanded.rs b/tests/expand/naming/struct-mut.expanded.rs
@@ -45,6 +45,7 @@ where
     clippy::redundant_pub_crate,
     clippy::single_char_lifetime_names,
     clippy::type_repetition_in_bounds,
+    clippy::missing_const_for_fn,
     clippy::needless_lifetimes,
     clippy::semicolon_if_nothing_returned,
     clippy::use_self,
@@ -76,7 +77,6 @@ const _: () = {
             }
         }
         #[allow(dead_code)]
-        #[allow(clippy::missing_const_for_fn)]
         #[inline]
         fn project_ref<'pin>(
             self: _pin_project::__private::Pin<&'pin Self>,

diff --git a/tests/expand/naming/struct-none.expanded.rs b/tests/expand/naming/struct-none.expanded.rs
@@ -20,6 +20,7 @@ struct Struct<T, U> {
     clippy::redundant_pub_crate,
     clippy::single_char_lifetime_names,
     clippy::type_repetition_in_bounds,
+    clippy::missing_const_for_fn,
     clippy::needless_lifetimes,
     clippy::semicolon_if_nothing_returned,
     clippy::use_self,
@@ -59,7 +60,6 @@ const _: () = {
             }
         }
         #[allow(dead_code)]
-        #[allow(clippy::missing_const_for_fn)]
         #[inline]
         fn project_ref<'pin>(
             self: _pin_project::__private::Pin<&'pin Self>,

diff --git a/tests/expand/naming/struct-own.expanded.rs b/tests/expand/naming/struct-own.expanded.rs
@@ -41,6 +41,7 @@ struct ProjOwn<T, U> {
     clippy::redundant_pub_crate,
     clippy::single_char_lifetime_names,
     clippy::type_repetition_in_bounds,
+    clippy::missing_const_for_fn,
     clippy::needless_lifetimes,
     clippy::semicolon_if_nothing_returned,
     clippy::use_self,
@@ -80,7 +81,6 @@ const _: () = {
             }
         }
         #[allow(dead_code)]
-        #[allow(clippy::missing_const_for_fn)]
         #[inline]
         fn project_ref<'pin>(
             self: _pin_project::__private::Pin<&'pin Self>,

diff --git a/tests/expand/naming/struct-ref.expanded.rs b/tests/expand/naming/struct-ref.expanded.rs
@@ -45,6 +45,7 @@ where
     clippy::redundant_pub_crate,
     clippy::single_char_lifetime_names,
     clippy::type_repetition_in_bounds,
+    clippy::missing_const_for_fn,
     clippy::needless_lifetimes,
     clippy::semicolon_if_nothing_returned,
     clippy::use_self,
@@ -76,7 +77,6 @@ const _: () = {
             }
         }
         #[allow(dead_code)]
-        #[allow(clippy::missing_const_for_fn)]
         #[inline]
         fn project_ref<'pin>(
             self: _pin_project::__private::Pin<&'pin Self>,

diff --git a/tests/expand/naming/tuple_struct-all.expanded.rs b/tests/expand/naming/tuple_struct-all.expanded.rs
@@ -82,6 +82,7 @@ struct ProjOwn<T, U>(::pin_project::__private::PhantomData<T>, U);
     clippy::redundant_pub_crate,
     clippy::single_char_lifetime_names,
     clippy::type_repetition_in_bounds,
+    clippy::missing_const_for_fn,
     clippy::needless_lifetimes,
     clippy::semicolon_if_nothing_returned,
     clippy::use_self,
@@ -102,7 +103,6 @@ const _: () = {
             }
         }
         #[allow(dead_code)]
-        #[allow(clippy::missing_const_for_fn)]
         #[inline]
         fn project_ref<'pin>(
             self: _pin_project::__private::Pin<&'pin Self>,

diff --git a/tests/expand/naming/tuple_struct-mut.expanded.rs b/tests/expand/naming/tuple_struct-mut.expanded.rs
@@ -40,6 +40,7 @@ where
     clippy::redundant_pub_crate,
     clippy::single_char_lifetime_names,
     clippy::type_repetition_in_bounds,
+    clippy::missing_const_for_fn,
     clippy::needless_lifetimes,
     clippy::semicolon_if_nothing_returned,
     clippy::use_self,
@@ -67,7 +68,6 @@ const _: () = {
             }
         }
         #[allow(dead_code)]
-        #[allow(clippy::missing_const_for_fn)]
         #[inline]
         fn project_ref<'pin>(
             self: _pin_project::__private::Pin<&'pin Self>,

diff --git a/tests/expand/naming/tuple_struct-none.expanded.rs b/tests/expand/naming/tuple_struct-none.expanded.rs
@@ -16,6 +16,7 @@ struct TupleStruct<T, U>(#[pin] T, U);
     clippy::redundant_pub_crate,
     clippy::single_char_lifetime_names,
     clippy::type_repetition_in_bounds,
+    clippy::missing_const_for_fn,
     clippy::needless_lifetimes,
     clippy::semicolon_if_nothing_returned,
     clippy::use_self,
@@ -53,7 +54,6 @@ const _: () = {
             }
         }
         #[allow(dead_code)]
-        #[allow(clippy::missing_const_for_fn)]
         #[inline]
         fn project_ref<'pin>(
             self: _pin_project::__private::Pin<&'pin Self>,

diff --git a/tests/expand/naming/tuple_struct-own.expanded.rs b/tests/expand/naming/tuple_struct-own.expanded.rs
@@ -34,6 +34,7 @@ struct ProjOwn<T, U>(::pin_project::__private::PhantomData<T>, U);
     clippy::redundant_pub_crate,
     clippy::single_char_lifetime_names,
     clippy::type_repetition_in_bounds,
+    clippy::missing_const_for_fn,
     clippy::needless_lifetimes,
     clippy::semicolon_if_nothing_returned,
     clippy::use_self,
@@ -71,7 +72,6 @@ const _: () = {
             }
         }
         #[allow(dead_code)]
-        #[allow(clippy::missing_const_for_fn)]
         #[inline]
         fn project_ref<'pin>(
             self: _pin_project::__private::Pin<&'pin Self>,

diff --git a/tests/expand/naming/tuple_struct-ref.expanded.rs b/tests/expand/naming/tuple_struct-ref.expanded.rs
@@ -40,6 +40,7 @@ where
     clippy::redundant_pub_crate,
     clippy::single_char_lifetime_names,
     clippy::type_repetition_in_bounds,
+    clippy::missing_const_for_fn,
     clippy::needless_lifetimes,
     clippy::semicolon_if_nothing_returned,
     clippy::use_self,
@@ -70,7 +71,6 @@ const _: () = {
             }
         }
         #[allow(dead_code)]
-        #[allow(clippy::missing_const_for_fn)]
         #[inline]
         fn project_ref<'pin>(
             self: _pin_project::__private::Pin<&'pin Self>,

diff --git a/tests/expand/not_unpin/enum.expanded.rs b/tests/expand/not_unpin/enum.expanded.rs
@@ -75,6 +75,7 @@ where
     clippy::redundant_pub_crate,
     clippy::single_char_lifetime_names,
     clippy::type_repetition_in_bounds,
+    clippy::missing_const_for_fn,
     clippy::needless_lifetimes,
     clippy::semicolon_if_nothing_returned,
     clippy::use_self,
@@ -108,7 +109,6 @@ const _: () = {
             }
         }
         #[allow(dead_code)]
-        #[allow(clippy::missing_const_for_fn)]
         #[inline]
         fn project_ref<'pin>(
             self: _pin_project::__private::Pin<&'pin Self>,

diff --git a/tests/expand/not_unpin/struct.expanded.rs b/tests/expand/not_unpin/struct.expanded.rs
@@ -20,6 +20,7 @@ struct Struct<T, U> {
     clippy::redundant_pub_crate,
     clippy::single_char_lifetime_names,
     clippy::type_repetition_in_bounds,
+    clippy::missing_const_for_fn,
     clippy::needless_lifetimes,
     clippy::semicolon_if_nothing_returned,
     clippy::use_self,
@@ -59,7 +60,6 @@ const _: () = {
             }
         }
         #[allow(dead_code)]
-        #[allow(clippy::missing_const_for_fn)]
         #[inline]
         fn project_ref<'pin>(
             self: _pin_project::__private::Pin<&'pin Self>,

diff --git a/tests/expand/not_unpin/tuple_struct.expanded.rs b/tests/expand/not_unpin/tuple_struct.expanded.rs
@@ -16,6 +16,7 @@ struct TupleStruct<T, U>(#[pin] T, U);
     clippy::redundant_pub_crate,
     clippy::single_char_lifetime_names,
     clippy::type_repetition_in_bounds,
+    clippy::missing_const_for_fn,
     clippy::needless_lifetimes,
     clippy::semicolon_if_nothing_returned,
     clippy::use_self,
@@ -53,7 +54,6 @@ const _: () = {
             }
         }
         #[allow(dead_code)]
-        #[allow(clippy::missing_const_for_fn)]
         #[inline]
         fn project_ref<'pin>(
             self: _pin_project::__private::Pin<&'pin Self>,