Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for cargo-dinghy #133

Merged
merged 4 commits into from
Jun 10, 2023
Merged

Add support for cargo-dinghy #133

merged 4 commits into from
Jun 10, 2023

Conversation

notgull
Copy link
Contributor

@notgull notgull commented Jun 9, 2023

Closes #132

@taiki-e
Copy link
Owner

taiki-e commented Jun 9, 2023

cargo-dinghy's archive seems to be an archive of a directory containing binary, so perhaps bin field (example) is needed.

@notgull
Copy link
Contributor Author

notgull commented Jun 10, 2023

cargo-dinghy's archive seems to be an archive of a directory containing binary, so perhaps bin field (example) is needed.

Fixed!

@taiki-e
Copy link
Owner

taiki-e commented Jun 10, 2023

LGTM. Could you add cargo-dinghy to the following tool lists?

tool:
# cargo-watch/watchexec-cli is supported by cargo-binstall (through quickinstall)
# TODO: valgrind installation sometime hangs.
- cargo-hack,cargo-llvm-cov,cargo-minimal-versions,cargo-no-dev-deps,parse-changelog,cargo-udeps,cargo-valgrind,cargo-deny,cross,dprint,just,nextest,protoc,shellcheck,shfmt,wasm-pack,wasmtime,mdbook,mdbook-linkcheck,cargo-watch,grcov,watchexec-cli,cargo-tarpaulin,zola

tool:
# valgrind: installing snap to container is difficult...
- cargo-hack,cargo-llvm-cov,cargo-minimal-versions,cargo-no-dev-deps,parse-changelog,cargo-udeps,cargo-valgrind,cargo-deny,cross,dprint,just,nextest,protoc,shellcheck,shfmt,wasm-pack,wasmtime,mdbook,mdbook-linkcheck,cargo-watch,grcov,watchexec-cli,cargo-tarpaulin,zola

Copy link
Owner

@taiki-e taiki-e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@taiki-e taiki-e merged commit 7e750de into taiki-e:main Jun 10, 2023
@taiki-e
Copy link
Owner

taiki-e commented Jun 10, 2023

Published in 2.11.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for installing cargo-dinghy
3 participants