Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invoke llvm-cov show with -show-branches #308

Merged
merged 1 commit into from
Aug 24, 2023

Conversation

Swatinem
Copy link
Contributor

The Rust compiler will gain support for Branch Coverage in the future, so add the -show-branches flag to llvm-cov to take advantage of that support.

See rust-lang/rust#115061 which is an early proof of concept to output branch regions.

The Rust compiler will gain support for Branch Coverage in the future, so add the `-show-branches` flag to `llvm-cov` to take advantage of that support.
Copy link
Owner

@taiki-e taiki-e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Is it okay to merge this now? Or should I wait for your rust-lang/rust PR to be merged?

@Swatinem
Copy link
Contributor Author

I believe you can merge it right away, looks like LLVM output emits (empty) branch statistics even without this flag, so having it won’t hurt.

I assume it will also take quite some time for this to eventually become stable.

Bildschirmfoto 2023-08-24 um 16 33 36

@taiki-e taiki-e merged commit 240da8c into taiki-e:main Aug 24, 2023
@taiki-e
Copy link
Owner

taiki-e commented Aug 24, 2023

Published in 0.5.31.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants