Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect lockfile except when necessary to work around old cargo bugs #242

Merged
merged 1 commit into from
Apr 1, 2024

Conversation

taiki-e
Copy link
Owner

@taiki-e taiki-e commented Mar 31, 2024

For now, I think this is a reasonable compromise to progress #234 without breaking existing workflows such as what is mentioned in rust-lang/cargo#13523 (comment).
See #234 (comment) for more information.

Changes:

  • Respect the existing Cargo.lock with --version-range/--rust-version except when necessary to work around old cargo bugs.
    If you want to ensure that the existing Cargo.lock is respected in all cases, please use --locked.

FYI @epage

@taiki-e taiki-e added the A-version Area: --rust-version, --version-range, --version-step label Mar 31, 2024
@taiki-e taiki-e force-pushed the generate-lockfile branch 2 times, most recently from 3be9907 to c8e6133 Compare March 31, 2024 01:43
@taiki-e taiki-e merged commit 1bd00f4 into main Apr 1, 2024
27 checks passed
@taiki-e taiki-e deleted the generate-lockfile branch April 1, 2024 00:15
@taiki-e
Copy link
Owner Author

taiki-e commented Apr 1, 2024

Published in 0.6.24.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-version Area: --rust-version, --version-range, --version-step
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant