Implement the [registries] and [registry] tables #8
Conversation
|
Do we also want to include the |
There was a problem hiding this comment.
Is this correct here? It seems like it would make the definition be the environmental variable with the prefix and suffix stripped off rather than the full thing.
Here I have it implemented such that it's consistent with line 36. Later I fix it so that it includes the full environmental variable. Which is preferred?
There was a problem hiding this comment.
Thanks for the PR! This looks great!
Do we also want to include the
registries.crates-io.protocolvalue? Right now it's only on Nightly.
That field is not yet available in the current stable, but it would make sense to support it anyway since it has been stabilized and AFAIK there is no plan to revert the stabilization.
Is this correct here? It seems like it would make the definition be the environmental variable with the prefix and suffix stripped off rather than the full thing.
The current one in the main branch is incorrect. Thanks for fixing this.
|
As of commit |
|
Published in v0.1.6. |
[registries]table[registry]tableI've done my best to stay consistent with the design, structure, and style of the code so far, but let me know if there's anything I could polish up!
This adds theurlcrate as a dependency, since registry indices are specified as URLs. If you want to avoid this added dependency, we could use aStringinstead.For security purposes, I did not add the ability to read any data in any
credentials.tomlorcredentialsfiles. It will help ensure that users of this library won't read and/or send sensitive data somewhere accidentally. If in the future you make it so this library can read from those files, then I recommend you make it an opt-in sort of thing.