handle empty string rustc wrapper envs #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If RUSTC_WRAPPER/RUSTC_WORKSPACE_WRAPPER is set to an empty string then this overrides the config and tells cargo not to use a wrapper, per https://doc.rust-lang.org/cargo/reference/environment-variables.html#environment-variables-cargo-reads.
I spotted this when upgrading cargo-llvm-cov from an older version, as I have some CI environments where RUSTC_WRAPPER is set to an empty string and it broke cargo-llvm-cov's rustc version detection.