Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(table-addon): add requireSort option to table #9036

Merged
merged 4 commits into from
Sep 30, 2024
Merged

feat(table-addon): add requireSort option to table #9036

merged 4 commits into from
Sep 30, 2024

Conversation

40oleg
Copy link
Collaborator

@40oleg 40oleg commented Sep 15, 2024

Close #8785

@lumberjack-bot lumberjack-bot
Copy link

lumberjack-bot bot commented Sep 15, 2024 •
edited
Loading

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

@github-actions github-actions bot added the v4 4.0 candidate label Sep 15, 2024
@40oleg 40oleg marked this pull request as draft September 15, 2024 19:01
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 15, 2024 •
edited
Loading

Visit the preview URL for this PR (updated for commit 552101d):

https://taiga-previews--pr9036-feature-table-add-re-94xbdklt.web.app

(expires Mon, 30 Sep 2024 13:01:26 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 20bbff1ad19772ecf9c5134a84c0641b0d776f4a

@bundlemon BundleMon
Copy link

bundlemon bot commented Sep 15, 2024 •
edited
Loading

BundleMon

Unchanged files (5)
Status Path Size Limits
✅ demo/browser/main.(hash).js
 287.98KB +10%
✅ demo/browser/vendor.(hash).js
 247.14KB +10%
✅ demo/browser/runtime.(hash).js
 42.71KB +10%
✅ demo/browser/styles.(hash).css
 16.17KB +10%
✅ demo/browser/polyfills.(hash).js
 11.18KB +10%

Total files change -2B 0%

Groups updated (1)
Status Path Size Limits
✅ demo/browser/*..js
 7.14MB (+88B 0%) -

Final result: ✅

View report in BundleMon website ➡️

Current branch size history | Target branch size history

@40oleg 40oleg marked this pull request as ready for review September 29, 2024 18:36
@40oleg 40oleg changed the title #Draft Option for required sorter in Table feat(table-addon): add requireSort option to table Sep 29, 2024
@splincode splincode merged commit 38c5b20 into main Sep 30, 2024
32 of 38 checks passed
@splincode splincode deleted the feature/table-add-required-sort branch September 30, 2024 12:35
@taiga-family-bot taiga-family-bot mentioned this pull request Sep 30, 2024
Merged
@taiga-family-bot taiga-family-bot mentioned this pull request Oct 8, 2024
Merged
@splincode
Copy link
Member

@40oleg could you add cherry pick to v3.x, please?

dequubi pushed a commit to dequubi/taiga-ui that referenced this pull request Oct 14, 2024
@40oleg
feat(addon-table): add requireSort option to table (taiga-family#9036)
3204fc5 
Co-authored-by: 40oleg <oleg.merkulov701@gmail.com>

(cherry picked from commit 38c5b20)
@dequubi
Copy link

dequubi commented Oct 14, 2024

Cherry-picked to v3 #9487

@taiga-family-bot taiga-family-bot mentioned this pull request Oct 14, 2024
Merged
nsbarsukov pushed a commit to dequubi/taiga-ui that referenced this pull request Oct 15, 2024
@40oleg @nsbarsukov
feat(addon-table): add requireSort option to table (taiga-family#9036)
67b4bea 
Co-authored-by: 40oleg <oleg.merkulov701@gmail.com>

(cherry picked from commit 38c5b20)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@splincode splincode splincode approved these changes

@waterplea waterplea waterplea approved these changes

@MarsiBarsi MarsiBarsi Awaiting requested review from MarsiBarsi

@vladimirpotekhin vladimirpotekhin Awaiting requested review from vladimirpotekhin

@nsbarsukov nsbarsukov Awaiting requested review from nsbarsukov

@mdlufy mdlufy Awaiting requested review from mdlufy

Assignees

@40oleg 40oleg

Labels
v4 4.0 candidate
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🚀 - option for required sorter in Table
4 participants
@40oleg @splincode @dequubi @waterplea