-
Notifications
You must be signed in to change notification settings - Fork 455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(schematics): add manual migration #7458
Conversation
splincode
commented
May 16, 2024
•
edited
Loading
edited
Sweep: PR ReviewSweep has finished reviewing your pull request. projects/cdk/schematics/collection.jsonA new private schematic "updateToV3_78" has been added to the configuration file to handle the migration of proprietary icons. Potential Issues
taiga-ui/projects/cdk/schematics/collection.json Lines 21 to 25 in 97cdecc
|
Pull request was closed ✔️All saved screenshots (for current PR) were deleted 🗑️ |
539db6e
to
22df10a
Compare
Visit the preview URL for this PR (updated for commit 97cdecc): https://taiga-ui--pr7458-splincode-manual-f2qr1nmf.web.app (expires Fri, 17 May 2024 14:13:35 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 4b5ece1e114386f6a105425ef799091475b249eb |
BundleMonFiles added (5)
Total files change +659.98KB Groups added (1)
Final result: ✅ View report in BundleMon website ➡️ |
"private": true, | ||
"description": "Manually run migration to update proprietary icons", | ||
"factory": "./ng-update/v3-78/index#updateToV3_78", | ||
"schema": "./ng-update/v3/schema.json" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
v3 schema.json
does not contains experimental
property
taiga-ui/projects/cdk/schematics/ng-update/v3/schema.json
Lines 6 to 12 in 0955f99
"properties": { | |
"skip-deep-imports": { | |
"description": "Ignore deep imports replacements", | |
"type": "boolean", | |
"default": false | |
} | |
} |
Should we create the separate ./ng-update/v3-78/schema.json
and use it here ?
22df10a
to
97cdecc
Compare