Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(addon-mobile): InputDateRange + MobileCalendar throw error on single date selection #9502

Merged
merged 1 commit into from
Oct 17, 2024
Merged

fix(addon-mobile): InputDateRange + MobileCalendar throw error on single date selection #9502

merged 1 commit into from
Oct 17, 2024

Conversation

nsbarsukov
Copy link
Member

Fixes #9351

@nsbarsukov nsbarsukov self-assigned this Oct 15, 2024
@lumberjack-bot lumberjack-bot
Copy link

lumberjack-bot bot commented Oct 15, 2024 •
edited
Loading

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

@github-actions github-actions bot added the v3 label Oct 15, 2024
@nsbarsukov nsbarsukov linked an issue Oct 15, 2024 that may be closed by this pull request
🐞 - Mobile InputDateRange breaks page when single date is selected #9351
Closed
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 15, 2024 •
edited
Loading

Visit the preview URL for this PR (updated for commit 20e9912):

https://taiga-ui--pr9502-input-date-range-bug-ij52365q.web.app

(expires Wed, 16 Oct 2024 12:16:05 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4b5ece1e114386f6a105425ef799091475b249eb

@bundlemon BundleMon
Copy link

bundlemon bot commented Oct 15, 2024 •
edited
Loading

BundleMon

Files added (5)
Status Path Size Limits
✅ demo/browser/main.(hash).js
 +397.44KB +10%
✅ demo/browser/vendor.(hash).js
 +214.53KB +10%
✅ demo/browser/runtime.(hash).js
 +42.05KB +10%
✅ demo/browser/polyfills.(hash).js
 +15.2KB +10%
✅ demo/browser/styles.(hash).css
 +1.39KB +10%

Total files change +670.62KB

Groups added (1)
Status Path Size Limits
✅ demo/browser/*..js
 +2.45MB -

Final result: ✅

View report in BundleMon website ➡️

Current branch size history

@nsbarsukov nsbarsukov marked this pull request as ready for review October 15, 2024 13:13
@raukouski
Copy link

Привет! Очень ждем этот фикс, ребят

@nsbarsukov nsbarsukov merged commit 086bda4 into v3.x Oct 17, 2024
32 of 33 checks passed
@nsbarsukov nsbarsukov deleted the input-date-range-bug-v3 branch October 17, 2024 12:22
@taiga-family-bot taiga-family-bot mentioned this pull request Oct 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdlufy mdlufy mdlufy approved these changes

@waterplea waterplea waterplea approved these changes

@MarsiBarsi MarsiBarsi Awaiting requested review from MarsiBarsi MarsiBarsi is a code owner

@vladimirpotekhin vladimirpotekhin Awaiting requested review from vladimirpotekhin vladimirpotekhin is a code owner

@splincode splincode Awaiting requested review from splincode splincode is a code owner

Assignees

@nsbarsukov nsbarsukov

Labels
ready to merge v3
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🐞 - Mobile InputDateRange breaks page when single date is selected
4 participants
@nsbarsukov @raukouski @waterplea @mdlufy