Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐞 - Mobile InputDateRange breaks page when single date is selected #9351

Closed
stanislav-osipov opened this issue Oct 4, 2024 · 2 comments · Fixed by #9411 or #9502
Closed

🐞 - Mobile InputDateRange breaks page when single date is selected #9351

stanislav-osipov opened this issue Oct 4, 2024 · 2 comments · Fixed by #9411 or #9502
Assignees
@nsbarsukov
Labels
bug Something isn't working P1 This issue has high priority S1 This issue has high severity

Comments

@stanislav-osipov
Copy link

Reproduction url

https://taiga-ui.dev/v3/components/input-date-range#base

Description

Can be reproduced in taiga v3 and v4

  1. Go to https://taiga-ui.dev/v3/components/input-date-range#base with mobile emulation
  2. Important: clear the value of input without opening calendar
  3. Click on any date (only one) once
  4. Click Done

Result:

TypeError: value.getFormattedDayRange is not a function is thrown multiple times so page is broken and has to be reloaded

Expected:

No value is set in control when only one date is selected - similar to desktop

Taiga UI version

3.94.0

Browser Used

Chrome

OS Used

Windows
@stanislav-osipov stanislav-osipov added bug Something isn't working state: need triage labels Oct 4, 2024
@waterplea waterplea added P1 This issue has high priority S1 This issue has high severity and removed state: need triage labels Oct 5, 2024
@nsbarsukov nsbarsukov self-assigned this Oct 8, 2024
@nsbarsukov nsbarsukov mentioned this issue Oct 9, 2024
Merged
@stanislav-osipov
Copy link
Author

stanislav-osipov commented Oct 11, 2024 •
edited
Loading

Hi @nsbarsukov,
will this fix be applied to v3?

@nsbarsukov
Copy link
Member

Hi @nsbarsukov, will this fix be applied to v3?

I'll cherry-pick this fix to v3 today 👍

@nsbarsukov nsbarsukov mentioned this issue Oct 15, 2024
Merged
@nsbarsukov nsbarsukov linked a pull request Oct 15, 2024 that will close this issue
fix(addon-mobile): InputDateRange + MobileCalendar throw error on single date selection #9502
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nsbarsukov nsbarsukov

Labels
bug Something isn't working P1 This issue has high priority S1 This issue has high severity
Milestone
No milestone
3 participants
@waterplea @stanislav-osipov @nsbarsukov